public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: Matt Turner <mattst88@gmail.com>
Cc: Michael Cree <mcree@orcon.net.nz>,
	linux-kernel@vger.kernel.org,
	Borislav Petkov <borislav.petkov@amd.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-alpha@vger.kernel.org, Chris Wright <chrisw@sous-sol.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: 2.6.35-rc2 compilation error on Alpha
Date: Tue, 8 Jun 2010 10:24:34 -0700	[thread overview]
Message-ID: <20100608172434.GK8301@sequoia.sous-sol.org> (raw)
In-Reply-To: <AANLkTinnprvU7bbe28emifv766_tWKjaSfW0ch2PQY23@mail.gmail.com>

* Matt Turner (mattst88@gmail.com) wrote:
> Fixes for both breaks are in:
>    git://git.kernel.org/pub/scm/linux/kernel/git/mattst88/alpha-2.6.git
> for-linus

Your 83926ce2dd37e4337ecf53b1e435d08e70b5871b will work, but you can
also simply drop the filp from pci_mmap_resource().  That's an internal
helper (local to alpha/kernel/pci-sysfs.c) and doesn't require the filp.
Sorry, that was my fault, and should be localized to 2.6.35-rc.

> I know alpha hardware isn't easy to get your hands on to compile test
> these changes, but guys, please just send linux-alpha@ the patch and
> _I'll_ do it. Both these breaks were not even compile tested.
> 
> pci break: 2c3c8bea608866d8bd9dcf92657d57fdcac011c5

$ git describe --contains 2c3c8bea608866d8bd9dcf92657d57fdcac011c5
v2.6.35-rc1~459^2~9

> hweight break: 1527bc8b928dd1399c3d3467dd47d9ede210978a
> 
> Greg, I haven't checked, but if either of these commits are in .34 or
> older, then my fixes need to go into -stable.

      parent reply	other threads:[~2010-06-08 17:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-06 22:35 2.6.35-rc2 compilation error on Alpha Michael Cree
2010-06-07  0:08 ` Matt Turner
2010-06-07  1:13   ` Michael Cree
2010-06-07  1:24     ` Matt Turner
2010-06-07  3:04       ` Greg KH
2010-06-08 17:24       ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100608172434.GK8301@sequoia.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=borislav.petkov@amd.com \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mcree@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox