From: Stephen Hemminger <shemminger@vyatta.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: floppy driver assumes INITIAL_JIFFIES == 0
Date: Tue, 8 Jun 2010 22:32:11 -0700 [thread overview]
Message-ID: <20100608223211.0c0bb1bc@nehalam> (raw)
In-Reply-To: <alpine.LFD.2.00.1006031618510.8175@i5.linux-foundation.org>
On Thu, 3 Jun 2010 16:21:55 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> On Thu, 3 Jun 2010, Stephen Hemminger wrote:
> >
> > Maybe putting all back together in a threaded_irq would be safest.
>
> Yes. That floppy driver could easily be a good case for using those
> threaded irq's. The problem, of course, is to find somebody motivated
> enough. The code-base really is pretty dang ugly, and it might be hard to
> do it incrementally, I think.
>
> (And starting from scratch is likely not a great idea either - while
> _some_ of the ugliness comes from the odd irq-driven state machine code, a
> lot of it also comes from trying to handle all those floppy formats etc)
>
> Linus
I have fixes to stop the panic, but will hold off until 2.6.36.
For now want to make sure that there is no chance of causing worse problems
on real hardware. There is no
reason there should ever be I/O error's and panic when running on virtual
hardware.
next prev parent reply other threads:[~2010-06-09 5:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 17:15 floppy driver assumes INITIAL_JIFFIES == 0 Stephen Hemminger
2010-06-03 17:28 ` Linus Torvalds
2010-06-03 19:03 ` Stephen Hemminger
2010-06-03 19:56 ` Linus Torvalds
2010-06-03 20:59 ` Linus Torvalds
2010-06-03 21:49 ` Stephen Hemminger
2010-06-03 21:58 ` Linus Torvalds
2010-06-03 22:33 ` Linus Torvalds
2010-06-03 22:54 ` Stephen Hemminger
2010-06-03 23:09 ` Linus Torvalds
2010-06-03 23:15 ` Stephen Hemminger
2010-06-03 23:21 ` Linus Torvalds
2010-06-09 5:32 ` Stephen Hemminger [this message]
2010-06-03 22:32 ` Andreas Mohr
2010-06-03 22:40 ` Linus Torvalds
2010-06-04 15:12 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100608223211.0c0bb1bc@nehalam \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox