Re: [PATCH v2] panic: keep blinking in spite of long spin timer mode

[Andrew Morton <akpm@linux-foundation.org>]

On Sun, 06 Jun 2010 22:19:18 +0900
TAMUKI Shoichi <tamuki@linet.gr.jp> wrote:

> Hello,
> 
> Thank you for the review.
> 
> On Thu, 3 Jun 2010 15:30:16 -0700 Andrew Morton wrote:
> 
> > > +	panicblink=	[KNL] The speed of panic blink (default is 12 wpm)
> > > +			The period of panic blink can be computed by the
> > > +			formula T = 7200 / W, where T is the period in milli-
> > > +			seconds, W is the speed in wpm (words per minute).
> > > +			Should be 5 or less when running under a hypervisor
> > 
> > Nobody will know what "wpm" means.  What is a "word" in this context?
> > Unclear.
> > 
> > How about "bpm": "blinks per minute".  That's nice and direct.
> 
> The current explanation of panicblink= still makes no sense, indeed.
> 
> "bpm" seems to be nice and direct, but the range at a practicable
> blinking speed will be 8.33 to 833 bpm.  That is too wide and the step
> size is too small for the speed of panic blink.  That will be hard to
> deal with.
> 
> OTOH, the range at a practicable blinking speed in "wpm" fits in 1 to
> 100.  I think that will sit well with us.
> 
> Now, I need to explain what "wpm" means and what a "word" in the con-
> text is:
> 
> The speed of morse code is measured in wpm, which defines the speed of
> morse transmission as the timing needed to send the word "PARIS" a
> given number of times per minute.
> 
> The time for one (minimum) unit can be computed by the formula T =
> 1200 / W, where T is the unit time in milliseconds, W is the speed in
> wpm.  The panic blink here is assumed as a word of infinite length to
> which "T" continues (i.e. "TTTTTTTT...").  The letter "T" represents
> three units long and the short gap (between letters) also represents
> three units long.  The period of panic blink thus can be computed by
> the formula T = 7200 / W.

Morse code?  Kidding?

Sorry, no.  Nobody who uses this feature will know what what
"words per minute" means.  It's nutty!

Please remind me why we're making this configurable at all.  Can't we
just hardwire the thing to 1Hz or something?  Add an
im_using_a_hypervisor boot option or something, if necessary?