From: Greg KH <greg@kroah.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@gmail.com
Subject: Re: [PATCH 1/1] PCI: hotplug/cpqphp, fix NULL dereference
Date: Wed, 9 Jun 2010 15:34:31 -0700 [thread overview]
Message-ID: <20100609223431.GD2533@kroah.com> (raw)
In-Reply-To: <1276115473-2307-1-git-send-email-jslaby@suse.cz>
On Wed, Jun 09, 2010 at 10:31:13PM +0200, Jiri Slaby wrote:
> There are devices out there which are PCI Hot-plug controllers with
> compaq PCI IDs, but are not bridges, hence have pdev->subordinate
> NULL. But cpqphp expects the pointer to be non-NULL.
>
> Add a check to the probe function to avoid oopses like:
> BUG: unable to handle kernel NULL pointer dereference at 00000050
> IP: [<f82e3c41>] cpqhpc_probe+0x951/0x1120 [cpqphp]
> *pdpt = 0000000033779001 *pde = 0000000000000000
> ...
>
> The device here was:
> 00:0b.0 PCI Hot-plug controller [0804]: Compaq Computer Corporation PCI Hotplug Controller [0e11:a0f7] (rev 11)
> Subsystem: Compaq Computer Corporation Device [0e11:a2f8]
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Greg KH <greg@kroah.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
thanks,
greg k-h
prev parent reply other threads:[~2010-06-09 22:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 20:31 [PATCH 1/1] PCI: hotplug/cpqphp, fix NULL dereference Jiri Slaby
2010-06-09 22:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609223431.GD2533@kroah.com \
--to=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox