From: Alexander Clouter <alex@digriz.org.uk>
To: Dmytro Milinevskyy <milinevskyy@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
Dhaval Vasa <dhaval.vasa@einfochips.com>,
Lennert Buytenhek <kernel@wantstofly.org>,
Nicolas Pitre <nico@fluxnic.net>,
Simon Guinot <sguinot@lacie.com>,
Martin Michlmayr <tbm@cyrius.com>,
Simon Kagstrom <simon.kagstrom@netinsight.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Marvell OpenRD-Ultimate machine support
Date: Thu, 10 Jun 2010 06:50:26 +0100 [thread overview]
Message-ID: <20100610055026.GM7660@chipmunk> (raw)
In-Reply-To: <4c104d7a.0c3ddf0a.2185.329a@mx.google.com>
Hi,
* Dmytro Milinevskyy <milinevskyy@gmail.com> [2010-06-10 05:24:56+0300]:
>
> [snipped]
>
> @@ -84,8 +90,7 @@ static void __init openrd_init(void)
>
> static int __init openrd_pci_init(void)
> {
> - if (machine_is_openrd_base() || machine_is_openrd_client())
> - kirkwood_pcie_init();
> + kirkwood_pcie_init();
>
> return 0;
> }
>
You just 'broke' kirkwood, welcome to the club. We all have done this:
http://marc.info/?l=linux-arm-kernel&m=125624586625065&w=2
http://marc.info/?l=linux-arm-kernel&m=125804222219159&w=2
Put that 'if()' clause back in, the 'subsys_initcall(openrd_pci_init)'
causes that code to run on *all* compiled in boards (think of the case
where you have SheevaPlug's also enabled).
Cheers
--
Alexander Clouter
.sigmonster says: Poverty begins at home.
next prev parent reply other threads:[~2010-06-10 5:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 2:24 [PATCH] Marvell OpenRD-Ultimate machine support Dmytro Milinevskyy
2010-06-10 5:50 ` Alexander Clouter [this message]
2010-06-10 6:15 ` Dmytro Milinevskyy
-- strict thread matches above, loose matches on Subject: below --
2010-06-10 19:12 Dmytro Milinevskyy
2010-06-12 8:29 ` Lennert Buytenhek
2010-06-09 20:14 Dmytro Milinevskyy
2010-06-09 20:37 ` Alexander Clouter
2010-06-09 20:39 ` Alexander Clouter
2010-06-09 20:42 ` Lennert Buytenhek
2010-06-10 1:56 ` Dmytro Milinevskyy
2010-06-08 19:47 Dmytro Milinevskyy
2010-06-09 7:25 ` Lennert Buytenhek
2010-06-09 7:37 ` Dmytro Milinevskyy
2010-06-08 17:24 Dmytro Milinevskyy
2010-06-08 17:38 ` Joe Perches
2010-06-08 17:45 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610055026.GM7660@chipmunk \
--to=alex@digriz.org.uk \
--cc=dhaval.vasa@einfochips.com \
--cc=kernel@wantstofly.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=milinevskyy@gmail.com \
--cc=nico@fluxnic.net \
--cc=sguinot@lacie.com \
--cc=simon.kagstrom@netinsight.net \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox