public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fredrik Gustafsson <iveqy@iveqy.com>
To: apw@canonical.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] checkpatch.pl skip long lines
Date: Sat, 12 Jun 2010 19:09:44 +0200	[thread overview]
Message-ID: <20100612170944.GA9121@iveqy.com> (raw)

Hi,
since the number of long lines in the linux kernel is huge and since
Greg Kroah Hartman in his google tech talk about the kernel
(http://www.youtube.com/watch?v=L2SED6sewRw) talked about probably
ignore that criteria in the future, I thought the checkpatch.pl script
should have an option to ignore checking for long lines.

This would help finding the real errors and warnings, because they don't
drown in line length warnings.

--
Regards
iveqy


>From ce6f2138969a56f5cbde2948f239c5204f0cafe1 Mon Sep 17 00:00:00 2001
From: iveqy <iveqy@iveqy.com>
Date: Sat, 12 Jun 2010 18:57:51 +0200
Subject: [PATCH] Add skiplinelength parameter

---
 scripts/checkpatch.pl |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bd88f11..e0683f4 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -29,6 +29,7 @@ my $summary_file = 0;
 my $root;
 my %debug;
 my $help = 0;
+my $skip_line_length = 0;
 
 sub help {
 	my ($exitcode) = @_;
@@ -49,6 +50,7 @@ Options:
   --root=PATH                PATH to the kernel tree root
   --no-summary               suppress the per-file summary
   --mailback                 only produce a report in case of warnings/errors
+  --skiplinelength           skip check for long lines
   --summary-file             include the filename in summary
   --debug KEY=[0|1]          turn on/off debugging of KEY, where KEY is one of
                              'values', 'possible', 'type', and 'attr' (default
@@ -81,6 +83,7 @@ GetOptions(
 	'debug=s'	=> \%debug,
 	'test-only=s'	=> \$tst_only,
 	'h|help'	=> \$help,
+	'skiplinelength!'	=> \$skip_line_length,
 	'version'	=> \$help
 ) or help(1);
 
@@ -1401,12 +1404,13 @@ sub process {
 		next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
 
 #80 column limit
-		if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
-		    $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
-		    $line !~ /^\+\s*$logFunctions\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
-		    $length > 80)
-		{
-			WARN("line over 80 characters\n" . $herecurr);
+		if(!$skip_line_length) {
+			if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
+				$rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
+				$line !~ /^\+\s*$logFunctions\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
+				$length > 80) {
+				WARN("line over 80 characters\n" . $herecurr);
+			}
 		}
 
 # check for spaces before a quoted newline
-- 
1.6.4.4


             reply	other threads:[~2010-06-12 17:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-12 17:09 Fredrik Gustafsson [this message]
2010-06-13  1:04 ` [PATCH] checkpatch.pl skip long lines Wolfram Sang
2010-06-13  5:36   ` Joe Perches
2010-06-13  5:49     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100612170944.GA9121@iveqy.com \
    --to=iveqy@iveqy.com \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox