From: Wolfram Sang <w.sang@pengutronix.de>
To: Fredrik Gustafsson <iveqy@iveqy.com>
Cc: apw@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl skip long lines
Date: Sun, 13 Jun 2010 03:04:29 +0200 [thread overview]
Message-ID: <20100613010429.GA31692@pengutronix.de> (raw)
In-Reply-To: <20100612170944.GA9121@iveqy.com>
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
On Sat, Jun 12, 2010 at 07:09:44PM +0200, Fredrik Gustafsson wrote:
> since the number of long lines in the linux kernel is huge and since
> Greg Kroah Hartman in his google tech talk about the kernel
> (http://www.youtube.com/watch?v=L2SED6sewRw) talked about probably
> ignore that criteria in the future, I thought the checkpatch.pl script
> should have an option to ignore checking for long lines.
>
> This would help finding the real errors and warnings, because they don't
> drown in line length warnings.
Instead of adding another command-line option, I'd suggest to just use CHK
instead of WARN, so this check will be enabled with --strict. I wonder if there
is already consensus on deprecating the 80-char-rule?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-06-13 1:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 17:09 [PATCH] checkpatch.pl skip long lines Fredrik Gustafsson
2010-06-13 1:04 ` Wolfram Sang [this message]
2010-06-13 5:36 ` Joe Perches
2010-06-13 5:49 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100613010429.GA31692@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=apw@canonical.com \
--cc=iveqy@iveqy.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox