Re: [PATCH v5 2/14] mm: Move replace_page to mm/memory.c

Srikar Dronamraju
2010-06-15T04:01:59Z

> On Mon, Jun 14, 2010 at 01:58:18PM +0530, Srikar Dronamraju wrote:
> > move_replace_page.patch
> >
> > From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> >
> > Move replace_page() and write_protect_page() to mm/memory.c
> >
> > User bkpt will use background page replacement approach to insert/delete
> > breakpoints. Background page replacement approach will be based on
> > replace_page and write_protect_page.
> > Now replace_page() loses its static attribute.
>
> Neither of these actually gets used in this series. So you can drop
> the patch for now.

replace_page() and write_protect_page() are used in write_opcode() to
insert/remove a breakpoint in the user-space breakpoint insertion layer.
i.e "[PATCH v5 3/14] User Space Breakpoint Assistance Layer"

Even if we merge uprobes and user_bkpt layers, we would still need
write_opcode function while inserting/deleting a breakpoint.

--
Thanks and Regards
Srikar