Re: [PATCH v5 1/14] X86 instruction analysis: Move Macro W to insn.h

Srikar Dronamraju
2010-06-15T06:34:48Z

* Christoph Hellwig <hch@infradead.org> [2010-06-14 13:39:26]:

> On Mon, Jun 14, 2010 at 01:58:03PM +0530, Srikar Dronamraju wrote:
> > move_W_to_insn.patch
> >
> > From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> >
> > Move Macro W to asm/insn.h
> >
> > Macro W used to know if the instructions are valid for
> > user-space/kernel space. This macro is used by kprobes and
> > user_bkpt. (i.e user space breakpoint assistance layer.) So moving it
> > to a common header file asm/insn.h.
>
> I don't think W is a good name for a macro in a header file.

Agree, Masami has also given the same comment earlier, I plan to move to
using inat tables instead of this macro.

--
Thanks and Regards
Srikar