Re: [PATCH v5 11/14] trace: uprobes trace_event interface

Christoph Hellwig
2010-06-22T06:35:31Z

On Tue, Jun 22, 2010 at 09:45:29AM +0530, Srikar Dronamraju wrote:
> As you see UPROBE_EVENT is gated on UPROBES. I think if UPROBES is
> enabled, then UPROBE_EVENT should be enabled. Esp with Christoph
> suggesting for module support to be removed, I think it becomes all the
> more reason for UPROBE_EVENT to be enabled by default. Otherwise there
> is no point in having uprobes code and having no enabled users.
> I was even looking at "select UPROBE_EVENT" on enabling UPROBES.
>
> Do you have any specific reason why UPROBE_EVENT should not be enabled
> by default?

default y generally is a big hammer. But given that it depends on
UPROBES it might be fine here. Then again the big question is why
we even bother with separate config options? At least in this form
UPROBES just is supported for UPROBE_EVENT. So it makes sense either
to remove the UPROBES option entirely, or at least make it invisible
to the user and let UPROBE_EVENT select it.