Re: [PATCH v5 11/14] trace: uprobes trace_event interface

Srikar Dronamraju
2010-06-22T04:19:08Z

>
> > +config UPROBE_EVENT
> > + depends on UPROBES
> > + bool "Enable uprobes-based dynamic events"
> > + select TRACING
> > + default y
>
> Why is this default y?

As you see UPROBE_EVENT is gated on UPROBES. I think if UPROBES is
enabled, then UPROBE_EVENT should be enabled. Esp with Christoph
suggesting for module support to be removed, I think it becomes all the
more reason for UPROBE_EVENT to be enabled by default. Otherwise there
is no point in having uprobes code and having no enabled users.
I was even looking at "select UPROBE_EVENT" on enabling UPROBES.

Do you have any specific reason why UPROBE_EVENT should not be enabled
by default?

--
Thanks and Regards
Srikar