Re: [PATCH v5 10/14] trace: Common code for kprobes/uprobes traceevents

Steven Rostedt
2010-06-21T14:18:23Z

On Mon, 2010-06-14 at 13:59 +0530, Srikar Dronamraju wrote:
> share_traceevents.patch.
>
> From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
> Changelog from v5: Addressed comments from Masami.
> Also shared lot more code from kprobes traceevents.
>
> Move common parts of trace_kprobe.c and trace_uprobec.
> Adjust kernel/trace/trace_kprobe.c after moving common code to
> kernel/trace/trace_probe.h. However they still have few duplicate
> functions.
>
> TODO: Merge both events to a single probe event.
>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
>
> kernel/trace/trace_kprobe.c | 141 +--------------------------------------
> kernel/trace/trace_probe.h | 157 +++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 161 insertions(+), 137 deletions(-)
> create mode 100644 kernel/trace/trace_probe.h
>

> diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h
> new file mode 100644
> index 0000000..b4c5763
> --- /dev/null
> +++ b/kernel/trace/trace_probe.h
> @@ -0,0 +1,157 @@
> +/*
> + * Common header file for probe-based Dynamic events.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> + *
> + * Copyright (C) IBM Corporation, 2010
> + * Author: Srikar Dronamraju

Note, when moving stuff from one file to another, you still need to keep
the copyright and author of the original file. You can add your name and
copyright as well, when you add your stuff to it.

-- Steve