Re: [PATCH v5 3/14] User Space Breakpoint Assistance Layer

Srikar Dronamraju
2010-06-15T11:30:07Z

* Christoph Hellwig <hch@infradead.org> [2010-06-14 13:50:48]:

> On Mon, Jun 14, 2010 at 01:58:32PM +0530, Srikar Dronamraju wrote:
> > TODO: Merge user_bkpt layer with uprobes.
>
> Yes, I don't think there's any point in that split. What's the
> timeframe for you to finish that merge?

I will take this up in v6.

>
> > + depends on MODULES
>
> This doesn't make too much sense - the only real user of this is not
> modular at all.

Okay.

>
> > + depends on HAVE_USER_BKPT
>
> Should this be ARCH_HAVE_USER_BKPT or similar?

Okay I shall change from HAVE_USER_BKPT to ARCH_HAVE_USER_BKPT.

--
Thanks and Regards
Srikar