Re: [PATCH v5 1/14] X86 instruction analysis: Move Macro W to insn.h

Christoph Hellwig
2010-06-14T17:40:29Z

On Mon, Jun 14, 2010 at 01:58:03PM +0530, Srikar Dronamraju wrote:
> move_W_to_insn.patch
>
> From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
> Move Macro W to asm/insn.h
>
> Macro W used to know if the instructions are valid for
> user-space/kernel space. This macro is used by kprobes and
> user_bkpt. (i.e user space breakpoint assistance layer.) So moving it
> to a common header file asm/insn.h.

I don't think W is a good name for a macro in a header file.