From: Christoph Hellwig <hch@lst.de>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Christoph Hellwig <hch@lst.de>,
"jens.axboe@oracle.com" <jens.axboe@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kyungmin Park <kmpark@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Madhusudhan Chikkature <madhu.cr@ti.com>
Subject: Re: [PATCH V2 0/4] Add MMC erase and secure erase
Date: Mon, 14 Jun 2010 13:21:50 +0200 [thread overview]
Message-ID: <20100614112150.GA5364@lst.de> (raw)
In-Reply-To: <4C160E0E.4010802@nokia.com>
On Mon, Jun 14, 2010 at 02:10:06PM +0300, Adrian Hunter wrote:
> Needs a bio flag, a request flag, setup the request flag based on the
> bio flag, prevent merging secure and non-secure discards, prevent drivers
> doing non-secure discards for secure discards.
>
> Seems like a lot of little changes for something that no one wants.
> Shouldn't it wait for someone to need it first?
I know that some people have asked for this. But if you want to keep
it in the driver for now that's fine to me. But in that case please:
(a) make it entirely driver private and leave no traces of it in the
block layer
(b) split it into a separate patch from the discard support
prev parent reply other threads:[~2010-06-14 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 10:01 [PATCH V2 0/4] Add MMC erase and secure erase Adrian Hunter
2010-06-13 10:38 ` Adrian Hunter
2010-06-14 8:09 ` Christoph Hellwig
2010-06-14 11:10 ` Adrian Hunter
2010-06-14 11:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614112150.GA5364@lst.de \
--to=hch@lst.de \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=madhu.cr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox