Re: [PATCH 1/3 V2] mfd: add STMPE811 core support

Mark Brown
2010-06-14T11:50:36Z

On Mon, Jun 14, 2010 at 12:32:36PM +0200, Luotao Fu wrote:

> +static void stmpe811_mask_work(struct work_struct *work)
> +{
> + struct stmpe811 *stm = container_of(work, struct stmpe811, mask_work);
> +
> + stmpe811_reg_write(stm, STMPE811_REG_INT_EN, stm->int_en_mask);
> +
> + mutex_unlock(&stm->irq_mask_lock);
> +}

Why are you doing this in a workqueue? You shouldn't need to do this -
you should implement the bus_lock() and bus_unlock() callbacks instead.

> + ret = request_threaded_irq(client->irq, NULL, stmpe811_irq,
> + pdata->irq_flags, "stmpe811", stm);
> + if (ret) {
> + dev_err(&client->dev, "failed to request IRQ: %d\n", ret);
> + goto err_free;
> + }

I suspect you should be unconditionally putting IRQF_ONESHOT here since
the threaded IRQ requires it.