From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: minyard@acm.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: Make sure drivers were registered before unregistering them
Date: Mon, 14 Jun 2010 21:47:01 +0100 [thread overview]
Message-ID: <20100614204701.GA32612@srcf.ucam.org> (raw)
In-Reply-To: <20100614133608.b343cb84.akpm@linux-foundation.org>
On Mon, Jun 14, 2010 at 01:36:08PM -0700, Andrew Morton wrote:
> On Thu, 10 Jun 2010 13:53:26 -0400
> Matthew Garrett <mjg@redhat.com> wrote:
>
> > The ipmi code will never register a PCI or Open Firmware driver if
> > a hardcoded device is provided by the user.
>
> How does a user "provide a hardcoded device"?
By providing device addresses via the module parameters. This is the
terminology used in the driver.
> I tried to work out from the above whether we want to backport this fix
> into -stable and failed. And I reckon that if I can't work this out
> from a changelog, the changelog is inadequate.
We don't. The change that caused this bug was merged post-.34.
> > #ifdef CONFIG_ACPI
> > @@ -3330,6 +3338,7 @@ static __devinit int init_ipmi_si(void)
> >
> > #ifdef CONFIG_PPC_OF
> > of_register_platform_driver(&ipmi_of_platform_driver);
> > + of_registered = 1;
>
> I assume the code will still oops if of_register_platform_driver() failed.
Indeed. I should fix that.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2010-06-14 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 17:53 [PATCH] ipmi: Make sure drivers were registered before unregistering them Matthew Garrett
2010-06-10 18:11 ` Corey Minyard
2010-06-14 20:36 ` Andrew Morton
2010-06-14 20:47 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614204701.GA32612@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox