From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040Ab0FOJTL (ORCPT ); Tue, 15 Jun 2010 05:19:11 -0400 Received: from poutre.nerim.net ([62.4.16.124]:51574 "EHLO poutre.nerim.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401Ab0FOJTI (ORCPT ); Tue, 15 Jun 2010 05:19:08 -0400 Date: Tue, 15 Jun 2010 11:19:02 +0200 From: Jean Delvare To: Peter Stuge , "Justin P. Mattock" Cc: Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, reiserfs-devel@vger.kernel.org, linux-bluetooth@vger.kernel.org, debora@linux.vnet.ibm.com, linux-i2c@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-media@vger.kernel.org Subject: Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used Message-ID: <20100615111902.373ac06d@hyperion.delvare> In-Reply-To: <20100615052944.7746.qmail@stuge.se> References: <1276547208-26569-1-git-send-email-justinmattock@gmail.com> <1276547208-26569-5-git-send-email-justinmattock@gmail.com> <21331.1276560832@localhost> <4C16E18F.9050901@gmail.com> <9275.1276573789@localhost> <4C16F9FC.2080905@gmail.com> <20100615052944.7746.qmail@stuge.se> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i586-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Jun 2010 07:29:44 +0200, Peter Stuge wrote: > Justin P. Mattock wrote: > > > *baffled* Why did you think that would work? transmit_cmd()s signature > > > has 4 parameters. > > > > I have no manual in front of me. Did a quick google, but came up with > > (no hits) info on what that function does. grep showed too many entries > > to really see why/what this is. Justin, I think you're on the wrong track here. You seem to be in a hurry to fix all these warnings generated by gcc 4.6. There is no hurry at all. Most warnings are false positives, and actual bugs may take some thinking and knowledge. So rushing is not needed and not desirable. Going too fast, you might even introduce new bugs, or prevent old bugs from being properly fixed. Warnings are a chance to make the code better. The goal is not to fix them quickly, but to fix them properly. If this is not your intent, then please stop immediately and let others deal with these warnings. If you want to help, this is appreciated, but what we need it quality, not quantity. > Check out the tool cscope. (Or kscope, if you prefer a GUI.) Or just LXR online if you don't want to install anything: http://lxr.linux.no/linux http://lxr.linux.no/#linux+v2.6.34/drivers/char/tpm/tpm.c#L451 -- Jean Delvare