From: Andrew Morton <akpm@linux-foundation.org>
To: dave.bueso@gmail.com
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uniform cdrom: fix mutex unlocking in /proc/sys/dev/cdrom/info file
Date: Tue, 15 Jun 2010 12:31:01 -0700 [thread overview]
Message-ID: <20100615123101.5b9addff.akpm@linux-foundation.org> (raw)
In-Reply-To: <1276627254.4666.0.camel@cowboy>
On Tue, 15 Jun 2010 14:40:54 -0400
Davidlohr Bueso <dave.bueso@gmail.com> wrote:
> Regarding cdrom_sysctl_info(), I have noticed in several netbooks
> (haven't
> looked in other machines with no cdrom drive) that the
> /proc/sys/dev/cdrom/info file shows no values for the listed entries,
> ie:
>
> CD-ROM information, Id: cdrom.c 3.20 2003/12/17
>
> drive name:
> drive speed:
> drive # of slots:
> Can close tray:
> Can open tray:
> ...
>
> Now, is this expected behavior? If not, should it be changed to
> something
> more descriptive? Perhaps it would affect user space applications that
> read
> the file?
It works for me.
Does your kernel build have CONFIG_SYSCTL=n? If so, then all that code
is disabled. That seems a bit bogus to me and perhaps we should enable
at least some of that code by CONFIG_PROCFS instead.
prev parent reply other threads:[~2010-06-15 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 16:56 [PATCH] uniform cdrom: fix mutex unlocking in /proc/sys/dev/cdrom/info file Davidlohr Bueso
2010-06-14 19:34 ` Andrew Morton
2010-06-15 18:40 ` Davidlohr Bueso
2010-06-15 19:31 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615123101.5b9addff.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dave.bueso@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox