From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "'Liam Girdwood'" <lrg@slimlogic.co.uk>,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com,
sameo@linux.intel.com
Subject: Re: [PATCH v2] drivers: regulator: add Maxim 8998 driver
Date: Tue, 15 Jun 2010 14:14:52 +0100 [thread overview]
Message-ID: <20100615131452.GF14510@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <00d801cb0c87$aae7b020$00b71060$%szyprowski@samsung.com>
On Tue, Jun 15, 2010 at 02:38:26PM +0200, Marek Szyprowski wrote:
> Are global exports preferred over the callbacks? I saw both in different
> MFD drivers and was not sure which one to use.
> I've selected callbacks, because they are a bit nicer and don't pollute
> the name space for each single driver. In my opinion the cost of these
> 3 max8998_reg_{read,write,update} inline functions in regulator/max8998.c
> is not so significant.
The dereferences looked fairly painful reading the code. You can always
do the global stuff as static inlines in the header file which avoids
namespace pollution while keeping the code looking like a function call.
next prev parent reply other threads:[~2010-06-15 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 12:03 [PATCH v2] drivers: regulator: add Maxim 8998 driver Marek Szyprowski
2010-06-15 12:12 ` Mark Brown
2010-06-15 12:38 ` Marek Szyprowski
2010-06-15 13:14 ` Mark Brown [this message]
2010-06-16 5:13 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615131452.GF14510@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox