RE: [PATCH v2] drivers: regulator: add Maxim 8998 driver

Marek Szyprowski
2010-06-15T12:39:37Z

Hello,

On Tuesday, June 15, 2010 2:12 PM Mark Brown wrote:

> On Tue, Jun 15, 2010 at 02:03:08PM +0200, Marek Szyprowski wrote:
> > From: Kyungmin Park <kyungmin.park@samsung.com>
>
> > This patch adds voltage regulator driver for Maxim 8998 chip. This chip
> > is used on Samsung Aquila and GONI boards and provides following
> > functionalities:
> > - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power
> > controllers
> > - battery charger
> > - RTC
>
> CCing in Samuel for the MFD part and hence not deleting any context.
>
> It'd be better to make the register read/write functions part of the MFD
> driver and export them (since the RTC and so on drivers will need the
> same stuff) but other than that this looks good and I've no comments. I
> suspect it'd be easier to review fixing the register write location as
> an incremental patch unless you need to respin for some other reason.
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Are global exports preferred over the callbacks? I saw both in different
MFD drivers and was not sure which one to use.

I've selected callbacks, because they are a bit nicer and don't pollute
the name space for each single driver. In my opinion the cost of these
3 max8998_reg_{read,write,update} inline functions in regulator/max8998.c
is not so significant.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center