From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
Sridhar Samudrala <sri@us.ibm.com>,
virtualization@lists.linux-foundation.org,
Jiri Pirko <jpirko@redhat.com>, Shirley Ma <xma@us.ibm.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-2.6.35] virtio_net: fix oom handling on tx
Date: Tue, 15 Jun 2010 13:53:29 +0930 [thread overview]
Message-ID: <201006151353.30529.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100610190343.GC4044@redhat.com>
On Fri, 11 Jun 2010 04:33:43 am Michael S. Tsirkin wrote:
> On Thu, Jun 10, 2010 at 10:46:53AM -0700, Stephen Hemminger wrote:
> > It makes more sense to have the device increment tx_droppped,
> > and return NETDEV_TX_OK. Skip the message (or make it a pr_debug()).
> > Network devices do not guarantee packet delivery, and if out of
> > resources then holding more data in the
> > queue is going to hurt not help the situation.
Yes, actually oom should be a ratelimited message and TX_OK, the other
case is a "should never happen" logic bug which warrants an error and
I don't care what it returns (whatever's easiest).
Please fix both at once since you're touching it.
Thanks,
Rusty.
next prev parent reply other threads:[~2010-06-15 4:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 15:20 [PATCH for-2.6.35] virtio_net: fix oom handling on tx Michael S. Tsirkin
2010-06-10 17:17 ` Sridhar Samudrala
2010-06-10 17:46 ` Stephen Hemminger
2010-06-10 19:03 ` Michael S. Tsirkin
2010-06-15 4:23 ` Rusty Russell [this message]
2010-06-21 2:43 ` Rusty Russell
2010-06-21 8:33 ` Michael S. Tsirkin
2010-06-21 10:23 ` Rusty Russell
2010-06-21 10:53 ` Michael S. Tsirkin
2010-06-10 18:57 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006151353.30529.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=sri@us.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xma@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox