From: Matthew Garrett <mjg@redhat.com>
To: Tomas Henzl <thenzl@redhat.com>
Cc: linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
linux-kernel@vger.kernel.org, kaneshige.kenji@jp.fujitsu.com
Subject: Re: [PATCH] pci: Don't enable aspm before drivers have had a chance to veto it
Date: Tue, 15 Jun 2010 16:32:56 +0100 [thread overview]
Message-ID: <20100615153256.GA20309@srcf.ucam.org> (raw)
In-Reply-To: <4C179C3E.6000702@redhat.com>
On Tue, Jun 15, 2010 at 05:29:02PM +0200, Tomas Henzl wrote:
> On 06/15/2010 05:18 PM, Matthew Garrett wrote:
> > On Tue, Jun 15, 2010 at 05:11:59PM +0200, Tomas Henzl wrote:
> >
> >
> >> Matthew, isn't it so that the POLICY_DEFAULT will pass the above test
> >> and possibly switch the ASPM on?
> >>
> > Yes. We assume that the BIOS authors aren't actively malicious.
> >
> I originally thought your patch is about not enabling ASPM on broken
> hardware (bios included) before the driver has a chance to change it.
Heh. No, if the BIOS set up ASPM on the controller, it seems like it's
safe to do the same. That's been the default behaviour of upstream for
some time now.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-06-15 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 20:05 [PATCH] pci: Don't enable aspm before drivers have had a chance to veto it Matthew Garrett
2010-06-10 2:05 ` Kenji Kaneshige
2010-06-15 15:11 ` Tomas Henzl
2010-06-15 15:18 ` Matthew Garrett
2010-06-15 15:29 ` Tomas Henzl
2010-06-15 15:32 ` Matthew Garrett [this message]
2010-06-18 12:06 ` Maxim Levitsky
2010-06-18 16:12 ` Jesse Barnes
2010-06-18 17:05 ` Maxim Levitsky
2010-06-18 17:08 ` Jesse Barnes
2010-06-18 17:15 ` Jesse Barnes
2010-06-18 17:44 ` Maxim Levitsky
2010-06-18 17:15 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615153256.GA20309@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox