public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] x86-32: remove CONFIG_4KSTACKS
Date: Wed, 16 Jun 2010 11:16:21 +0200	[thread overview]
Message-ID: <20100616091621.GA4486@lst.de> (raw)

These days 4 kilobytes of stack just aren't enough for reliably operation,
and people using lots of threads have long switched to x86-64, so remove the
CONFIG_4KSTACKS option.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/arch/x86/Kconfig.debug
===================================================================
--- linux-2.6.orig/arch/x86/Kconfig.debug	2010-06-16 10:24:06.902272433 +0200
+++ linux-2.6/arch/x86/Kconfig.debug	2010-06-16 10:24:11.837068354 +0200
@@ -121,15 +121,6 @@ config DEBUG_NX_TEST
 	  and the software setup of this feature.
 	  If in doubt, say "N"
 
-config 4KSTACKS
-	bool "Use 4Kb for kernel stacks instead of 8Kb"
-	depends on X86_32
-	---help---
-	  If you say Y here the kernel will use a 4Kb stacksize for the
-	  kernel stack attached to each process/thread. This facilitates
-	  running more threads on a system and also reduces the pressure
-	  on the VM subsystem for higher order allocations.
-
 config DOUBLEFAULT
 	default y
 	bool "Enable doublefault exception handler" if EMBEDDED
Index: linux-2.6/arch/x86/include/asm/module.h
===================================================================
--- linux-2.6.orig/arch/x86/include/asm/module.h	2010-06-16 10:24:06.922004449 +0200
+++ linux-2.6/arch/x86/include/asm/module.h	2010-06-16 10:24:23.255291640 +0200
@@ -60,12 +60,7 @@
 #endif
 
 #ifdef CONFIG_X86_32
-# ifdef CONFIG_4KSTACKS
-#  define MODULE_STACKSIZE "4KSTACKS "
-# else
-#  define MODULE_STACKSIZE ""
-# endif
-# define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY MODULE_STACKSIZE
+# define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY
 #endif
 
 #endif /* _ASM_X86_MODULE_H */
Index: linux-2.6/arch/x86/include/asm/page_32_types.h
===================================================================
--- linux-2.6.orig/arch/x86/include/asm/page_32_types.h	2010-06-16 10:24:06.933273132 +0200
+++ linux-2.6/arch/x86/include/asm/page_32_types.h	2010-06-16 10:24:30.251005496 +0200
@@ -15,11 +15,7 @@
  */
 #define __PAGE_OFFSET		_AC(CONFIG_PAGE_OFFSET, UL)
 
-#ifdef CONFIG_4KSTACKS
-#define THREAD_ORDER	0
-#else
 #define THREAD_ORDER	1
-#endif
 #define THREAD_SIZE 	(PAGE_SIZE << THREAD_ORDER)
 
 #define STACKFAULT_STACK 0

             reply	other threads:[~2010-06-16  9:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-16  9:16 Christoph Hellwig [this message]
2010-06-16 10:21 ` [PATCH] x86-32: remove CONFIG_4KSTACKS Alan Cox
2010-06-16 10:20   ` Christoph Hellwig
2010-06-16 10:23     ` Kyle McMartin
2010-06-16 10:46       ` Milan Broz
2010-06-16 10:49         ` Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100616091621.GA4486@lst.de \
    --to=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox