From: Christoph Hellwig <hch@lst.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Christoph Hellwig <hch@lst.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86-32: remove CONFIG_4KSTACKS
Date: Wed, 16 Jun 2010 12:20:51 +0200 [thread overview]
Message-ID: <20100616102051.GA7731@lst.de> (raw)
In-Reply-To: <20100616112136.42ab08ef@lxorguk.ukuu.org.uk>
On Wed, Jun 16, 2010 at 11:21:36AM +0100, Alan Cox wrote:
> On Wed, 16 Jun 2010 11:16:21 +0200
> Christoph Hellwig <hch@lst.de> wrote:
>
> > These days 4 kilobytes of stack just aren't enough for reliably operation,
> > and people using lots of threads have long switched to x86-64, so remove the
> > CONFIG_4KSTACKS option.
>
> It's very useful for things like debugging and because of the split
> kernel/irq stacks.
Ingo just ACKed my previous patch to make irq stacks unconditional.
> It also seems to be quite adequate for most
> configurations.
See the direct reclaim flamewar. Currently we can end up in ->writepage
from af_unix poll code with over 3k stack alreay used. It's certainly
not anywhere near enough.
> Perhaps XFS should select 8K stack instead ?
or rather !CONFIG_INSANE. I don't care too much. No one sane should
ever enable it anymore, but Ingo asked me to send a patch to remove it.
next prev parent reply other threads:[~2010-06-16 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 9:16 [PATCH] x86-32: remove CONFIG_4KSTACKS Christoph Hellwig
2010-06-16 10:21 ` Alan Cox
2010-06-16 10:20 ` Christoph Hellwig [this message]
2010-06-16 10:23 ` Kyle McMartin
2010-06-16 10:46 ` Milan Broz
2010-06-16 10:49 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100616102051.GA7731@lst.de \
--to=hch@lst.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox