[PATCH] IPMI: Set schedule_timeout_wait value back to one

[PATCH] IPMI: Set schedule_timeout_wait value back to one

[Corey Minyard]

From: Martin Wilck <martin.wilck@ts.fujitsu.com>

Some systems were seeing CPU usage go up dramatically with the recent
changes to try to reduce timer usage in the IPMI driver.  This was
traced down to schedule_timeout_interruptible(1) being changed to
schedule_timeout_interruptbile(0).  Revert that change.

Reported-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Tested-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---

Index: linux-2.6/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux-2.6.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2.6/drivers/char/ipmi/ipmi_si_intf.c
@@ -1018,7 +1018,7 @@ static int ipmi_thread(void *data)
 		else if (smi_result == SI_SM_IDLE)
 			schedule_timeout_interruptible(100);
 		else
-			schedule_timeout_interruptible(0);
+			schedule_timeout_interruptible(1);
 	}
 	return 0;
 }

Re: [PATCH] IPMI: Set schedule_timeout_wait value back to one

[Andrew Morton]

On Wed, 16 Jun 2010 08:51:44 -0500
Corey Minyard <minyard@acm.org> wrote:

> From: Martin Wilck <martin.wilck@ts.fujitsu.com>
> 
> Some systems were seeing CPU usage go up dramatically with the recent
> changes to try to reduce timer usage in the IPMI driver.  This was
> traced down to schedule_timeout_interruptible(1) being changed to
> schedule_timeout_interruptbile(0).  Revert that change.
> 
> Reported-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> Tested-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
> 
> Index: linux-2.6/drivers/char/ipmi/ipmi_si_intf.c
> ===================================================================
> --- linux-2.6.orig/drivers/char/ipmi/ipmi_si_intf.c
> +++ linux-2.6/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1018,7 +1018,7 @@ static int ipmi_thread(void *data)
>  		else if (smi_result == SI_SM_IDLE)
>  			schedule_timeout_interruptible(100);
>  		else
> -			schedule_timeout_interruptible(0);
> +			schedule_timeout_interruptible(1);
>  	}
>  	return 0;
>  }

This fixes a regression introduced by ae74e823cb7d ("ipmi: add
parameter to limit CPU usage in kipmid"), yes?  I noted that in the
changelog.

I also noted that it addresses
https://bugzilla.kernel.org/show_bug.cgi?id=16147 and I added the
vital(!) cc:stable@kernel.org, as we busted 2.6.34.

This is a pretty important -stable fix I think - several people have
hit it and the effects are ugly.