Re: [PATCH 9/9] oom: give the dying task a higher priority

KOSAKI Motohiro
2010-06-17T01:56:54Z

> > + struct sched_param param = { .sched_priority = 1 };
> > +
> > + if (mem)
> > + return;
> > +
> > + if (rt_task(p)) {
> > + p->rt.time_slice = HZ;
> > + return;
>
> I have a question from long time ago.
> If we change rt.time_slice _without_ setscheduler, is it effective?
> I mean scheduler pick up the task faster than other normal task?

if p is SCHED_OTHER, no effective. if my understand is correct, that's
only meaningfull if p is SCHED_RR. that's the reason why I moved this
check into "if (rt_task())".

but honestly I haven't observed this works effectively. so, I agree
this can be removed as Luis mentioned.