From: "Charles Clément" <caratorn@gmail.com>
To: John Sheehan <john.d.sheehan@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, rich.folsom@gmail.com,
mithlesh@linsyssoft.com, jirislaby@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: comedi: fix style errors in adl_pci9111.c
Date: Wed, 16 Jun 2010 12:28:04 -0700 [thread overview]
Message-ID: <20100616192803.GA11073@fujitsu> (raw)
In-Reply-To: <1276713009-8499-1-git-send-email-john.d.sheehan@gmail.com>
Hi,
On Wed, Jun 16, 2010 at 07:30:09PM +0100, John Sheehan wrote:
> From: John Sheehan <john.d.sheehan@gmail.com>
> @@ -190,7 +190,7 @@ TODO:
> outb(flags, PCI9111_IO_BASE+PCI9111_REGISTER_TRIGGER_MODE_CONTROL)
>
> #define pci9111_interrupt_and_fifo_get() \
> - ((inb(PCI9111_IO_BASE+PCI9111_REGISTER_AD_MODE_INTERRUPT_READBACK) >> 4) &0x03)
> + ((inb(PCI9111_IO_BASE+PCI9111_REGISTER_AD_MODE_INTERRUPT_READBACK) >> 4)&0x03)
Doesn't checkpatch.pl suggest to add a whitespace after the & in that case?
It would seem more readable.
--
Charles Clément
next prev parent reply other threads:[~2010-06-16 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 18:30 [PATCH 1/2] Staging: comedi: fix style errors in adl_pci9111.c John Sheehan
2010-06-16 19:28 ` Charles Clément [this message]
[not found] ` <AANLkTil0ezKl6SbtvGe0Vn_d6RX789NMAnwvRKheDUaK@mail.gmail.com>
2010-06-20 20:02 ` Charles Clément
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100616192803.GA11073@fujitsu \
--to=caratorn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=john.d.sheehan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mithlesh@linsyssoft.com \
--cc=rich.folsom@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox