* [PATCH] perf: avoid synthesizing mmap() for all processes in per-thread mode perf record
@ 2010-06-16 18:59 Stephane Eranian
2010-06-16 20:50 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Stephane Eranian @ 2010-06-16 18:59 UTC (permalink / raw)
To: linux-kernel
Cc: peterz, mingo, paulus, davem, fweisbec, acme, perfmon2-devel,
eranian, eranian
A bug was introduced by commit c45c6ea2e5c57960dc67e00294c2b78e9540c007.
Perf record was scanning /proc/PID to create synthetic PERF_RECOR_MMAP
entries even though it was running in per-thread mode. There was a bogus
check to select what mmaps to synthesize. We only need all processes in
system-wide mode.
Signed-off-by: Stephane Eranian <eranian@google.com>
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 39c7247..5efc3fc 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -714,7 +714,7 @@ static int __cmd_record(int argc, const char **argv)
if (perf_guest)
perf_session__process_machines(session, event__synthesize_guest_os);
- if (!system_wide && cpu_list)
+ if (!system_wide)
event__synthesize_thread(target_tid, process_synthesized_event,
session);
else
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf: avoid synthesizing mmap() for all processes in per-thread mode perf record
2010-06-16 18:59 [PATCH] perf: avoid synthesizing mmap() for all processes in per-thread mode perf record Stephane Eranian
@ 2010-06-16 20:50 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2010-06-16 20:50 UTC (permalink / raw)
To: Stephane Eranian
Cc: linux-kernel, peterz, mingo, paulus, davem, fweisbec,
perfmon2-devel, eranian
Em Wed, Jun 16, 2010 at 08:59:01PM +0200, Stephane Eranian escreveu:
> A bug was introduced by commit c45c6ea2e5c57960dc67e00294c2b78e9540c007.
>
> Perf record was scanning /proc/PID to create synthetic PERF_RECOR_MMAP
> entries even though it was running in per-thread mode. There was a bogus
> check to select what mmaps to synthesize. We only need all processes in
> system-wide mode.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Thanks, appling to perf/urgent
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-16 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-16 18:59 [PATCH] perf: avoid synthesizing mmap() for all processes in per-thread mode perf record Stephane Eranian
2010-06-16 20:50 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox