[patch] get rid of "cut here" from bug output

[patch] get rid of "cut here" from bug output

[Dan Carpenter]

It's annoying to have chunks of dmesg output instead just the whole
output.  A lot of times the very interesting information is before
the bug happens.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/kernel/panic.c b/kernel/panic.c
index 3b16cd9..2db532a 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
 {
 	const char *board;
 
-	printk(KERN_WARNING "------------[ cut here ]------------\n");
+	printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");
 	printk(KERN_WARNING "WARNING: at %s:%d %pS()\n", file, line, caller);
 	board = dmi_get_system_info(DMI_PRODUCT_NAME);
 	if (board)

Re: [patch] get rid of "cut here" from bug output

[Borislav Petkov]

From: Dan Carpenter <error27@gmail.com>
Date: Thu, Jun 17, 2010 at 02:21:56PM +0200

> It's annoying to have chunks of dmesg output instead just the whole
> output.  A lot of times the very interesting information is before
> the bug happens.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> 
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 3b16cd9..2db532a 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
>  {
>  	const char *board;
>  
> -	printk(KERN_WARNING "------------[ cut here ]------------\n");
> +	printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");

Good idea, we end up requesting the whole dmesg most of the time anyway.
However not all bugs are reported through bugzilla, and, frankly
bugzilla is kinda sucky when it comes down to communicating with the bug
reporter. How about the more generic "send whole dmesg when reporting"
instead?

-- 
Regards/Gruss,
Boris.

Operating Systems Research Center
Advanced Micro Devices, Inc.

Re: [patch] get rid of "cut here" from bug output

[Andrew Morton]

On Thu, 17 Jun 2010 14:36:37 +0200 Borislav Petkov <bp@amd64.org> wrote:

> From: Dan Carpenter <error27@gmail.com>
> Date: Thu, Jun 17, 2010 at 02:21:56PM +0200
> 
> > It's annoying to have chunks of dmesg output instead just the whole
> > output.  A lot of times the very interesting information is before
> > the bug happens.
> > 
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > 
> > diff --git a/kernel/panic.c b/kernel/panic.c
> > index 3b16cd9..2db532a 100644
> > --- a/kernel/panic.c
> > +++ b/kernel/panic.c
> > @@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
> >  {
> >  	const char *board;
> >  
> > -	printk(KERN_WARNING "------------[ cut here ]------------\n");
> > +	printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");
> 
> Good idea, we end up requesting the whole dmesg most of the time anyway.
> However not all bugs are reported through bugzilla, and, frankly
> bugzilla is kinda sucky when it comes down to communicating with the bug
> reporter. How about the more generic "send whole dmesg when reporting"
> instead?

And the pestiferous thing wordwraps the dmesg output to death, making
it amazingly hard to read.  s/paste/attach/ maybe.

Re: [patch] get rid of "cut here" from bug output

[Borislav Petkov]

From: Andrew Morton <akpm@linux-foundation.org>
Date: Fri, Jun 18, 2010 at 02:19:02AM -0400

> On Thu, 17 Jun 2010 14:36:37 +0200 Borislav Petkov <bp@amd64.org> wrote:
> 
> > From: Dan Carpenter <error27@gmail.com>
> > Date: Thu, Jun 17, 2010 at 02:21:56PM +0200
> > 
> > > It's annoying to have chunks of dmesg output instead just the whole
> > > output.  A lot of times the very interesting information is before
> > > the bug happens.
> > > 
> > > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > > 
> > > diff --git a/kernel/panic.c b/kernel/panic.c
> > > index 3b16cd9..2db532a 100644
> > > --- a/kernel/panic.c
> > > +++ b/kernel/panic.c
> > > @@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
> > >  {
> > >  	const char *board;
> > >  
> > > -	printk(KERN_WARNING "------------[ cut here ]------------\n");
> > > +	printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");
> > 
> > Good idea, we end up requesting the whole dmesg most of the time anyway.
> > However not all bugs are reported through bugzilla, and, frankly
> > bugzilla is kinda sucky when it comes down to communicating with the bug
> > reporter. How about the more generic "send whole dmesg when reporting"
> > instead?
> 
> And the pestiferous thing wordwraps the dmesg output to death, making
> it amazingly hard to read.  s/paste/attach/ maybe.

Right, good point.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632