From: Ingo Molnar <mingo@elte.hu>
To: Corinna Schultz <cschultz@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, coschult@us.ibm.com,
akpm@linux-foundation.org, djwong <djwong@linux.vnet.ibm.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: [PATCH RESEND] Calgary: increase max PHB number
Date: Fri, 18 Jun 2010 11:40:05 +0200 [thread overview]
Message-ID: <20100618094005.GC23977@elte.hu> (raw)
In-Reply-To: <20100615161528.wqx1w1y3ok08w88w@imap.linux.ibm.com>
* Corinna Schultz <cschultz@linux.vnet.ibm.com> wrote:
> Newer systems (x3950M2) can have 48 PHBs per chassis and 8 chassis,
> so bump the
> limits up and provide an explanation of the requirements for each class.
>
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
> ---
>
> arch/x86/kernel/pci-calgary_64.c | 13 +++++++++----
> 1 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/pci-calgary_64.c
> b/arch/x86/kernel/pci-calgary_64.c
> index e6ec8a2..4b7eb90 100644
> --- a/arch/x86/kernel/pci-calgary_64.c
> +++ b/arch/x86/kernel/pci-calgary_64.c
> @@ -102,10 +102,15 @@ int use_calgary __read_mostly = 0;
> #define PMR_SOFTSTOPFAULT 0x40000000
> #define PMR_HARDSTOP 0x20000000
>
> -#define MAX_NUM_OF_PHBS 8 /* how many PHBs in total? */
> -#define MAX_NUM_CHASSIS 8 /* max number of chassis */
> -/* MAX_PHB_BUS_NUM is the maximal possible dev->bus->number */
> -#define MAX_PHB_BUS_NUM (MAX_NUM_OF_PHBS * MAX_NUM_CHASSIS * 2)
> +/*
> + * The maximum PHB bus number.
> + * x3950M2 (rare): 8 chassis, 48 PHBs per chassis = 384
> + * x3950M2: 4 chassis, 48 PHBs per chassis = 192
> + * x3950 (PCIE): 8 chassis, 32 PHBs per chassis = 256
> + * x3950 (PCIX): 8 chassis, 16 PHBs per chassis = 128
> + */
> +#define MAX_PHB_BUS_NUM 384
> +
Which tree is this against? Doesnt apply to .35-rc3:
Hunk #1 FAILED at 102.
1 out of 1 hunk FAILED -- rejects in file arch/x86/kernel/pci-calgary_64.c
Thanks,
Ingo
prev parent reply other threads:[~2010-06-18 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 20:15 [PATCH RESEND] Calgary: increase max PHB number Corinna Schultz
2010-06-18 9:40 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100618094005.GC23977@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=coschult@us.ibm.com \
--cc=cschultz@linux.vnet.ibm.com \
--cc=djwong@linux.vnet.ibm.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox