public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dan Carpenter <error27@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [patch] get rid of "cut here" from bug output
Date: Fri, 18 Jun 2010 12:00:42 +0200	[thread overview]
Message-ID: <20100618100042.GA1905@aftab> (raw)
In-Reply-To: <20100617231902.9ce1e33e.akpm@linux-foundation.org>

From: Andrew Morton <akpm@linux-foundation.org>
Date: Fri, Jun 18, 2010 at 02:19:02AM -0400

> On Thu, 17 Jun 2010 14:36:37 +0200 Borislav Petkov <bp@amd64.org> wrote:
> 
> > From: Dan Carpenter <error27@gmail.com>
> > Date: Thu, Jun 17, 2010 at 02:21:56PM +0200
> > 
> > > It's annoying to have chunks of dmesg output instead just the whole
> > > output.  A lot of times the very interesting information is before
> > > the bug happens.
> > > 
> > > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > > 
> > > diff --git a/kernel/panic.c b/kernel/panic.c
> > > index 3b16cd9..2db532a 100644
> > > --- a/kernel/panic.c
> > > +++ b/kernel/panic.c
> > > @@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
> > >  {
> > >  	const char *board;
> > >  
> > > -	printk(KERN_WARNING "------------[ cut here ]------------\n");
> > > +	printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");
> > 
> > Good idea, we end up requesting the whole dmesg most of the time anyway.
> > However not all bugs are reported through bugzilla, and, frankly
> > bugzilla is kinda sucky when it comes down to communicating with the bug
> > reporter. How about the more generic "send whole dmesg when reporting"
> > instead?
> 
> And the pestiferous thing wordwraps the dmesg output to death, making
> it amazingly hard to read.  s/paste/attach/ maybe.

Right, good point.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

      reply	other threads:[~2010-06-18  9:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 12:21 [patch] get rid of "cut here" from bug output Dan Carpenter
2010-06-17 12:36 ` Borislav Petkov
2010-06-18  6:19   ` Andrew Morton
2010-06-18 10:00     ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100618100042.GA1905@aftab \
    --to=bp@amd64.org \
    --cc=akpm@linux-foundation.org \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox