From: Ralf Baechle <ralf@linux-mips.org>
To: "Gleb O. Raiko" <raiko@niisi.msk.ru>
Cc: David Daney <ddaney@caviumnetworks.com>,
Jesper Nilsson <jesper@jni.nu>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: MIPS: return after handling coprocessor 2 exception
Date: Fri, 18 Jun 2010 13:14:03 +0100 [thread overview]
Message-ID: <20100618121403.GC4466@linux-mips.org> (raw)
In-Reply-To: <4C1B4C0A.9070506@niisi.msk.ru>
On Fri, Jun 18, 2010 at 02:35:54PM +0400, Gleb O. Raiko wrote:
> >static int default_cu2_call(struct notifier_block *nfb, unsigned long action,
> > void *data)
> >{
> > ...
> >
> > return NOTIFY_OK | NOTIFY_STOP;
> NOTIFY_STOP implies NOTIFY_OK, so
> return NOTIFY_STOP;
> shall be enough.
Correct - I was thinking NOTIFY_STOP_MASK.
> >}
>
> >The notifier list could also be used for example by perf
>
> Or octeon cop2 handler that just sends NOTIFY_BAD for getting the
> same behavior.
Bad karma to return an error for where none happened.
Ralf
prev parent reply other threads:[~2010-06-18 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 13:25 MIPS: return after handling coprocessor 2 exception Jesper Nilsson
2010-06-17 17:13 ` David Daney
2010-06-17 19:04 ` Jesper Nilsson
2010-06-18 7:54 ` Gleb O. Raiko
2010-06-18 10:00 ` Ralf Baechle
2010-06-18 10:35 ` Gleb O. Raiko
2010-06-18 12:14 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100618121403.GC4466@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney@caviumnetworks.com \
--cc=jesper@jni.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=raiko@niisi.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox