public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andres Salomon <dilinger@queued.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	mingo@redhat.com, x86@kernel.org, Mitch Bradley <wmb@laptop.org>
Subject: Re: [PATCH] x86: OLPC: add support for calling into OpenFirmware (v5)
Date: Fri, 18 Jun 2010 21:56:56 +0200	[thread overview]
Message-ID: <20100618195656.GA3821@elte.hu> (raw)
In-Reply-To: <4C1BCDD5.5040805@zytor.com>


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 06/18/2010 12:42 PM, Andres Salomon wrote:
> > +
> > +	/* install OFW's PDE permanently into the kernel's pgtable */
> > +	set_pgd(&swapper_pg_dir[OLPC_OFW_PDE_NR], *ofw_pde);
> > +	flush_tlb();
> > +	early_iounmap(base, sizeof(olpc_ofw_pgd) * PTRS_PER_PGD);
> 
> I just realized... this flush_tlb() is actually not necessary since on x86 
> it is always legal to go from a less permissive configuration to a more 
> permissive, and the initial configuration is "not present" which is 
> maximally nonpermissive.
> 
> Could you take it out and make sure it still works?

small nit: an optimization barrier would still be needed if the result is 
being relied on by the kernel.

Thanks,

	Ingo

  reply	other threads:[~2010-06-18 19:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-18 19:42 [PATCH] x86: OLPC: add support for calling into OpenFirmware (v5) Andres Salomon
2010-06-18 19:49 ` H. Peter Anvin
2010-06-18 19:56   ` Ingo Molnar [this message]
2010-06-18 20:00     ` H. Peter Anvin
2010-06-19  7:43       ` Ingo Molnar
2010-06-18 20:19   ` Andres Salomon
2010-06-18 20:24     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100618195656.GA3821@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=dilinger@queued.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wmb@laptop.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox