From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Dave Airlie <airlied@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"dri-devel" <dri-devel@lists.freedesktop.org>,
linux-pm@lists.linux-foundation.org,
Alex Deucher <alexdeucher@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ondrej Zary <linux@rainbow-software.org>
Subject: [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation
Date: Fri, 18 Jun 2010 22:21:57 +0200 [thread overview]
Message-ID: <201006182221.57333.rjw@sisk.pl> (raw)
From: Rafael J. Wysocki <rjw@sisk.pl>
I have recently noticed a 55 sec. delay during the "device freeze"
phase of hibernation on my test-bed HP nx6325. Due to the 100%
reproducibility of it I was able to narrow it down to
radeon_suspend_kms() and then it turned out that the delay occured
somewhere in radeon_bo_evict_vram(). However, it doesn't seem really
necessary or even very useful to me to evict VRAM at this particular
point, because we're going to create an image and bring the device
back to the fully functional state in a little while. Thus, I think
the VRAM evicition can be skipped for state.event == PM_EVENT_FREEZE,
which makes the delay go away.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/gpu/drm/radeon/radeon_device.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/gpu/drm/radeon/radeon_device.c
===================================================================
--- linux-2.6.orig/drivers/gpu/drm/radeon/radeon_device.c
+++ linux-2.6/drivers/gpu/drm/radeon/radeon_device.c
@@ -750,8 +750,11 @@ int radeon_suspend_kms(struct drm_device
}
}
}
- /* evict vram memory */
- radeon_bo_evict_vram(rdev);
+
+ if (state.event != PM_EVENT_FREEZE) {
+ /* evict vram memory */
+ radeon_bo_evict_vram(rdev);
+ }
/* wait for gpu to finish processing current batch */
radeon_fence_wait_last(rdev);
next reply other threads:[~2010-06-18 20:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 20:21 Rafael J. Wysocki [this message]
2010-06-18 20:42 ` [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation Rafał Miłecki
2010-06-18 23:19 ` Rafael J. Wysocki
2010-06-18 21:08 ` Dave Airlie
2010-06-18 23:23 ` Rafael J. Wysocki
2010-06-18 23:49 ` Dave Airlie
2010-06-19 12:53 ` Rafael J. Wysocki
2010-06-19 23:43 ` Rafael J. Wysocki
2010-06-21 7:57 ` Jerome Glisse
2010-06-21 20:44 ` Rafael J. Wysocki
2010-06-19 13:21 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006182221.57333.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox