The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: nanakos@wired-net.gr
Cc: gregkh@suse.de, horms@verge.net.au, hsweeten@visionengravers.com,
	ss@aao.gov.au, randy.dunlap@oracle.com, tj@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: dt3155: dt3155_drv.c: Fix checkpatch.pl issues.
Date: Fri, 18 Jun 2010 16:45:22 -0700	[thread overview]
Message-ID: <20100618234522.GA19602@kroah.com> (raw)
In-Reply-To: <1274988042-7716-2-git-send-email-nanakos@wired-net.gr>

On Thu, May 27, 2010 at 07:20:42PM +0000, nanakos@wired-net.gr wrote:
> From: Nanakos Chrysostomos <nanakos@wired-net.gr>
> 
> Fix resolves checkpatch.pl issues for dt3155_drv.c file.

No, it breaks the build, and changes the logic a bit.  Please always at
least test-build your patches, it saves me a lot of time...

I can't apply this one, sorry.

greg k-h

  reply	other threads:[~2010-06-18 23:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27 19:20 [PATCH] Staging: dt3155: dt3155_isr.c: Fix checkpatch.pl issues nanakos
2010-05-27 19:20 ` [PATCH] Staging: dt3155: dt3155_drv.c: " nanakos
2010-06-18 23:45   ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-05-29 13:18 Nanakos Chrysostomos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100618234522.GA19602@kroah.com \
    --to=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=horms@verge.net.au \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nanakos@wired-net.gr \
    --cc=randy.dunlap@oracle.com \
    --cc=ss@aao.gov.au \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox