From: Arjan van de Ven <arjan@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Kees Cook <kees.cook@canonical.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Alexander Potashev <aspotashev@gmail.com>,
Tim Abbott <tabbott@ksplice.com>, Sam Ravnborg <sam@ravnborg.org>,
Jan Beulich <jbeulich@novell.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] x86: clear XD_DISABLED flag on Intel to regain NX
Date: Sat, 19 Jun 2010 08:16:42 -0700 [thread overview]
Message-ID: <20100619081642.33b37676@infradead.org> (raw)
In-Reply-To: <874ogzph4m.fsf@basil.nowhere.org>
On Sat, 19 Jun 2010 10:21:29 +0200
Andi Kleen <andi@firstfloor.org> wrote:
> Kees Cook <kees.cook@canonical.com> writes:
>
> > This will clear the MSR_IA32_MISC_ENABLE_XD_DISABLE bit so that NX
> > cannot be inappropriately controlled by the BIOS on Intel CPUs. If
> > NX actually needs to be disabled, "noexec=off" can be used.
>
> The patch still seems like a bad idea to me. What happens if
> the NX bit is broken for some reason and the BIOS is right
> to disable it?
overriding the bios like this is almost always a bad idea.
(you're doing a blanket override, not a specific, verified override)
you have no idea if the SMM code can deal with NX, etc etc.
the real answer is "fix your bios setting".
Don't as owner of the machine turn something off in the bios that you
actually want.
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2010-06-19 15:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 5:50 [PATCH v2 0/4] x86: clear XD_DISABLED flag on Intel to regain NX Kees Cook
2010-06-19 5:51 ` [PATCH 1/4] x86: rename verify_cpu_64.S to verify_cpu.S Kees Cook
2010-06-19 5:52 ` [PATCH 2/4] x86: clear XD_DISABLED flag on Intel to regain NX Kees Cook
2010-06-19 5:52 ` [PATCH 3/4] x86: call verify_cpu during 32bit CPU startup Kees Cook
2010-06-19 5:53 ` [PATCH 4/4] x86: only CPU features determine NX capabilities Kees Cook
2010-06-19 8:21 ` [PATCH v2 0/4] x86: clear XD_DISABLED flag on Intel to regain NX Andi Kleen
2010-06-19 15:16 ` Arjan van de Ven [this message]
2010-06-19 17:54 ` Kees Cook
2010-06-19 18:08 ` H. Peter Anvin
2010-06-19 16:21 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100619081642.33b37676@infradead.org \
--to=arjan@infradead.org \
--cc=andi@firstfloor.org \
--cc=aspotashev@gmail.com \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=tabbott@ksplice.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox