* PCMCIA regression @ 2010-05-25 20:25 Mikulas Patocka 2010-05-26 7:14 ` Justin P. Mattock 2010-05-26 11:35 ` Dominik Brodowski 0 siblings, 2 replies; 7+ messages in thread From: Mikulas Patocka @ 2010-05-25 20:25 UTC (permalink / raw) To: Dominik Brodowski; +Cc: linux-kernel Hi The commit a8408c17d0038b76a83affb1b56dc18fa1e7ed86 in Linux 2.6.34-rc6 broke pcmcia for me. I use 3c574 network card in yenta socket on Armada 7400 laptop. My distribution is Debian lenny. Reverting the test for "s->functions" in pccard_validate_cis makes the network card work again. Mikulas May 20 14:17:21 gerlinda vmunix: ------------[ cut here ]------------ May 20 14:17:21 gerlinda vmunix: WARNING: at drivers/pcmcia/cistpl.c:1488 pccard_validate_cis+0x287/0x2d0 [pcmcia]() May 20 14:17:21 gerlinda vmunix: Modules linked in: 3c574_cs ohci_hcd pcmcia rtc_cmos crc32 ide_cd_mod rtc_core usbcore rtc_lib yenta_socket cdrom psmouse pcspkr rsrc_nonstatic nls_base pcmcia_core unix May 20 14:17:21 gerlinda vmunix: Pid: 1486, comm: pccardd Not tainted 2.6.34-fast #15 May 20 14:17:21 gerlinda vmunix: Call Trace: May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? pccard_validate_cis+0x287/0x2d0 [pcmcia] May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? pccard_validate_cis+0x287/0x2d0 [pcmcia] May 20 14:17:21 gerlinda vmunix: [<c10207d6>] ? warn_slowpath_common+0x76/0xd0 May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? pccard_validate_cis+0x287/0x2d0 [pcmcia] May 20 14:17:21 gerlinda vmunix: [<c1020843>] ? warn_slowpath_null+0x13/0x20 May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? pccard_validate_cis+0x287/0x2d0 [pcmcia] May 20 14:17:21 gerlinda vmunix: [<cc83517a>] ? pcmcia_nonstatic_validate_mem+0xda/0x180 [rsrc_nonstatic] May 20 14:17:21 gerlinda vmunix: [<c10ce0af>] ? sysfs_addrm_finish+0x7f/0xb0 May 20 14:17:21 gerlinda vmunix: [<cc9587c2>] ? pcmcia_card_add+0x72/0xf0 [pcmcia] May 20 14:17:21 gerlinda vmunix: [<c10f39e0>] ? kobject_release+0x0/0xa0 May 20 14:17:21 gerlinda vmunix: [<c10f44c9>] ? kref_put+0x29/0x60 May 20 14:17:21 gerlinda vmunix: [<cc9577cc>] ? pcmcia_card_remove+0x8c/0xa0 [pcmcia] May 20 14:17:21 gerlinda vmunix: [<cc958a24>] ? pcmcia_requery+0x74/0x130 [pcmcia] May 20 14:17:21 gerlinda vmunix: [<c101af4e>] ? set_next_entity+0x2e/0x70 May 20 14:17:21 gerlinda vmunix: [<c101c500>] ? do_sched_setscheduler+0x90/0xa0May 20 14:17:21 gerlinda vmunix: [<c11c0883>] ? schedule+0x203/0x3c0 May 20 14:17:21 gerlinda vmunix: [<cc818109>] ? pccardd+0x219/0x470 [pcmcia_core] May 20 14:17:21 gerlinda vmunix: [<c11c095a>] ? schedule+0x2da/0x3c0 May 20 14:17:21 gerlinda vmunix: [<cc817ef0>] ? pccardd+0x0/0x470 [pcmcia_core]May 20 14:17:21 gerlinda vmunix: [<c1035124>] ? kthread+0x74/0x80 May 20 14:17:21 gerlinda vmunix: [<c10350b0>] ? kthread+0x0/0x80 May 20 14:17:21 gerlinda vmunix: [<c10030f6>] ? kernel_thread_helper+0x6/0x10 May 20 14:17:21 gerlinda vmunix: ---[ end trace 256ec3e16d1d0f46 ]--- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PCMCIA regression 2010-05-25 20:25 PCMCIA regression Mikulas Patocka @ 2010-05-26 7:14 ` Justin P. Mattock 2010-05-26 11:27 ` Mikulas Patocka 2010-05-26 11:35 ` Dominik Brodowski 1 sibling, 1 reply; 7+ messages in thread From: Justin P. Mattock @ 2010-05-26 7:14 UTC (permalink / raw) To: Mikulas Patocka; +Cc: Dominik Brodowski, linux-kernel On 05/25/2010 01:25 PM, Mikulas Patocka wrote: > Hi > > The commit a8408c17d0038b76a83affb1b56dc18fa1e7ed86 in Linux 2.6.34-rc6 > broke pcmcia for me. I use 3c574 network card in yenta socket on Armada > 7400 laptop. My distribution is Debian lenny. > > Reverting the test for "s->functions" in pccard_validate_cis makes the > network card work again. > > Mikulas > > May 20 14:17:21 gerlinda vmunix: ------------[ cut here ]------------ > May 20 14:17:21 gerlinda vmunix: WARNING: at drivers/pcmcia/cistpl.c:1488 > pccard_validate_cis+0x287/0x2d0 [pcmcia]() > May 20 14:17:21 gerlinda vmunix: Modules linked in: 3c574_cs ohci_hcd > pcmcia rtc_cmos crc32 ide_cd_mod rtc_core usbcore rtc_lib yenta_socket > cdrom psmouse pcspkr rsrc_nonstatic nls_base pcmcia_core unix > May 20 14:17:21 gerlinda vmunix: Pid: 1486, comm: pccardd Not tainted > 2.6.34-fast #15 > May 20 14:17:21 gerlinda vmunix: Call Trace: > May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? > pccard_validate_cis+0x287/0x2d0 [pcmcia] > May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? > pccard_validate_cis+0x287/0x2d0 [pcmcia] > May 20 14:17:21 gerlinda vmunix: [<c10207d6>] ? > warn_slowpath_common+0x76/0xd0 May 20 14:17:21 gerlinda vmunix: > [<cc95cc57>] ? pccard_validate_cis+0x287/0x2d0 [pcmcia] > May 20 14:17:21 gerlinda vmunix: [<c1020843>] ? > warn_slowpath_null+0x13/0x20 > May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? > pccard_validate_cis+0x287/0x2d0 [pcmcia] > May 20 14:17:21 gerlinda vmunix: [<cc83517a>] ? > pcmcia_nonstatic_validate_mem+0xda/0x180 [rsrc_nonstatic] > May 20 14:17:21 gerlinda vmunix: [<c10ce0af>] ? > sysfs_addrm_finish+0x7f/0xb0 > May 20 14:17:21 gerlinda vmunix: [<cc9587c2>] ? pcmcia_card_add+0x72/0xf0 > [pcmcia] > May 20 14:17:21 gerlinda vmunix: [<c10f39e0>] ? kobject_release+0x0/0xa0 > May 20 14:17:21 gerlinda vmunix: [<c10f44c9>] ? kref_put+0x29/0x60 > May 20 14:17:21 gerlinda vmunix: [<cc9577cc>] ? > pcmcia_card_remove+0x8c/0xa0 [pcmcia] > May 20 14:17:21 gerlinda vmunix: [<cc958a24>] ? pcmcia_requery+0x74/0x130 > [pcmcia] > May 20 14:17:21 gerlinda vmunix: [<c101af4e>] ? set_next_entity+0x2e/0x70 > May 20 14:17:21 gerlinda vmunix: [<c101c500>] ? > do_sched_setscheduler+0x90/0xa0May 20 14:17:21 gerlinda vmunix: > [<c11c0883>] ? schedule+0x203/0x3c0 > May 20 14:17:21 gerlinda vmunix: [<cc818109>] ? pccardd+0x219/0x470 > [pcmcia_core] > May 20 14:17:21 gerlinda vmunix: [<c11c095a>] ? schedule+0x2da/0x3c0 > May 20 14:17:21 gerlinda vmunix: [<cc817ef0>] ? pccardd+0x0/0x470 > [pcmcia_core]May 20 14:17:21 gerlinda vmunix: [<c1035124>] ? > kthread+0x74/0x80 > May 20 14:17:21 gerlinda vmunix: [<c10350b0>] ? kthread+0x0/0x80 > May 20 14:17:21 gerlinda vmunix: [<c10030f6>] ? > kernel_thread_helper+0x6/0x10 > May 20 14:17:21 gerlinda vmunix: ---[ end trace 256ec3e16d1d0f46 ]--- > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > maybe this is similar: https://bugzilla.kernel.org/show_bug.cgi?id=16015 Justin P. Mattock ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PCMCIA regression 2010-05-26 7:14 ` Justin P. Mattock @ 2010-05-26 11:27 ` Mikulas Patocka 2010-05-26 13:29 ` Justin P. Mattock 0 siblings, 1 reply; 7+ messages in thread From: Mikulas Patocka @ 2010-05-26 11:27 UTC (permalink / raw) To: Justin P. Mattock; +Cc: Dominik Brodowski, linux-kernel On Wed, 26 May 2010, Justin P. Mattock wrote: > On 05/25/2010 01:25 PM, Mikulas Patocka wrote: > > Hi > > > > The commit a8408c17d0038b76a83affb1b56dc18fa1e7ed86 in Linux 2.6.34-rc6 > > broke pcmcia for me. I use 3c574 network card in yenta socket on Armada > > 7400 laptop. My distribution is Debian lenny. > > > > Reverting the test for "s->functions" in pccard_validate_cis makes the > > network card work again. > > > > Mikulas > > > > May 20 14:17:21 gerlinda vmunix: ------------[ cut here ]------------ > > May 20 14:17:21 gerlinda vmunix: WARNING: at drivers/pcmcia/cistpl.c:1488 > > pccard_validate_cis+0x287/0x2d0 [pcmcia]() > > May 20 14:17:21 gerlinda vmunix: Modules linked in: 3c574_cs ohci_hcd > > pcmcia rtc_cmos crc32 ide_cd_mod rtc_core usbcore rtc_lib yenta_socket > > cdrom psmouse pcspkr rsrc_nonstatic nls_base pcmcia_core unix > > May 20 14:17:21 gerlinda vmunix: Pid: 1486, comm: pccardd Not tainted > > 2.6.34-fast #15 > > May 20 14:17:21 gerlinda vmunix: Call Trace: > > May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? > > pccard_validate_cis+0x287/0x2d0 [pcmcia] > > May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? > > pccard_validate_cis+0x287/0x2d0 [pcmcia] > > May 20 14:17:21 gerlinda vmunix: [<c10207d6>] ? > > warn_slowpath_common+0x76/0xd0 May 20 14:17:21 gerlinda vmunix: > > [<cc95cc57>] ? pccard_validate_cis+0x287/0x2d0 [pcmcia] > > May 20 14:17:21 gerlinda vmunix: [<c1020843>] ? > > warn_slowpath_null+0x13/0x20 > > May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? > > pccard_validate_cis+0x287/0x2d0 [pcmcia] > > May 20 14:17:21 gerlinda vmunix: [<cc83517a>] ? > > pcmcia_nonstatic_validate_mem+0xda/0x180 [rsrc_nonstatic] > > May 20 14:17:21 gerlinda vmunix: [<c10ce0af>] ? > > sysfs_addrm_finish+0x7f/0xb0 > > May 20 14:17:21 gerlinda vmunix: [<cc9587c2>] ? pcmcia_card_add+0x72/0xf0 > > [pcmcia] > > May 20 14:17:21 gerlinda vmunix: [<c10f39e0>] ? kobject_release+0x0/0xa0 > > May 20 14:17:21 gerlinda vmunix: [<c10f44c9>] ? kref_put+0x29/0x60 > > May 20 14:17:21 gerlinda vmunix: [<cc9577cc>] ? > > pcmcia_card_remove+0x8c/0xa0 [pcmcia] > > May 20 14:17:21 gerlinda vmunix: [<cc958a24>] ? pcmcia_requery+0x74/0x130 > > [pcmcia] > > May 20 14:17:21 gerlinda vmunix: [<c101af4e>] ? set_next_entity+0x2e/0x70 > > May 20 14:17:21 gerlinda vmunix: [<c101c500>] ? > > do_sched_setscheduler+0x90/0xa0May 20 14:17:21 gerlinda vmunix: > > [<c11c0883>] ? schedule+0x203/0x3c0 > > May 20 14:17:21 gerlinda vmunix: [<cc818109>] ? pccardd+0x219/0x470 > > [pcmcia_core] > > May 20 14:17:21 gerlinda vmunix: [<c11c095a>] ? schedule+0x2da/0x3c0 > > May 20 14:17:21 gerlinda vmunix: [<cc817ef0>] ? pccardd+0x0/0x470 > > [pcmcia_core]May 20 14:17:21 gerlinda vmunix: [<c1035124>] ? > > kthread+0x74/0x80 > > May 20 14:17:21 gerlinda vmunix: [<c10350b0>] ? kthread+0x0/0x80 > > May 20 14:17:21 gerlinda vmunix: [<c10030f6>] ? > > kernel_thread_helper+0x6/0x10 > > May 20 14:17:21 gerlinda vmunix: ---[ end trace 256ec3e16d1d0f46 ]--- > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > > > maybe this is similar: > > https://bugzilla.kernel.org/show_bug.cgi?id=16015 > > Justin P. Mattock No, it's different. The bug that I have is a code logic error, the function pccard_validate_cis is called when it shouldn't be. Mikulas ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PCMCIA regression 2010-05-26 11:27 ` Mikulas Patocka @ 2010-05-26 13:29 ` Justin P. Mattock 0 siblings, 0 replies; 7+ messages in thread From: Justin P. Mattock @ 2010-05-26 13:29 UTC (permalink / raw) To: Mikulas Patocka; +Cc: Dominik Brodowski, linux-kernel On 05/26/2010 04:27 AM, Mikulas Patocka wrote: > > On Wed, 26 May 2010, Justin P. Mattock wrote: > > >> On 05/25/2010 01:25 PM, Mikulas Patocka wrote: >> >>> Hi >>> >>> The commit a8408c17d0038b76a83affb1b56dc18fa1e7ed86 in Linux 2.6.34-rc6 >>> broke pcmcia for me. I use 3c574 network card in yenta socket on Armada >>> 7400 laptop. My distribution is Debian lenny. >>> >>> Reverting the test for "s->functions" in pccard_validate_cis makes the >>> network card work again. >>> >>> Mikulas >>> >>> May 20 14:17:21 gerlinda vmunix: ------------[ cut here ]------------ >>> May 20 14:17:21 gerlinda vmunix: WARNING: at drivers/pcmcia/cistpl.c:1488 >>> pccard_validate_cis+0x287/0x2d0 [pcmcia]() >>> May 20 14:17:21 gerlinda vmunix: Modules linked in: 3c574_cs ohci_hcd >>> pcmcia rtc_cmos crc32 ide_cd_mod rtc_core usbcore rtc_lib yenta_socket >>> cdrom psmouse pcspkr rsrc_nonstatic nls_base pcmcia_core unix >>> May 20 14:17:21 gerlinda vmunix: Pid: 1486, comm: pccardd Not tainted >>> 2.6.34-fast #15 >>> May 20 14:17:21 gerlinda vmunix: Call Trace: >>> May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? >>> pccard_validate_cis+0x287/0x2d0 [pcmcia] >>> May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? >>> pccard_validate_cis+0x287/0x2d0 [pcmcia] >>> May 20 14:17:21 gerlinda vmunix: [<c10207d6>] ? >>> warn_slowpath_common+0x76/0xd0 May 20 14:17:21 gerlinda vmunix: >>> [<cc95cc57>] ? pccard_validate_cis+0x287/0x2d0 [pcmcia] >>> May 20 14:17:21 gerlinda vmunix: [<c1020843>] ? >>> warn_slowpath_null+0x13/0x20 >>> May 20 14:17:21 gerlinda vmunix: [<cc95cc57>] ? >>> pccard_validate_cis+0x287/0x2d0 [pcmcia] >>> May 20 14:17:21 gerlinda vmunix: [<cc83517a>] ? >>> pcmcia_nonstatic_validate_mem+0xda/0x180 [rsrc_nonstatic] >>> May 20 14:17:21 gerlinda vmunix: [<c10ce0af>] ? >>> sysfs_addrm_finish+0x7f/0xb0 >>> May 20 14:17:21 gerlinda vmunix: [<cc9587c2>] ? pcmcia_card_add+0x72/0xf0 >>> [pcmcia] >>> May 20 14:17:21 gerlinda vmunix: [<c10f39e0>] ? kobject_release+0x0/0xa0 >>> May 20 14:17:21 gerlinda vmunix: [<c10f44c9>] ? kref_put+0x29/0x60 >>> May 20 14:17:21 gerlinda vmunix: [<cc9577cc>] ? >>> pcmcia_card_remove+0x8c/0xa0 [pcmcia] >>> May 20 14:17:21 gerlinda vmunix: [<cc958a24>] ? pcmcia_requery+0x74/0x130 >>> [pcmcia] >>> May 20 14:17:21 gerlinda vmunix: [<c101af4e>] ? set_next_entity+0x2e/0x70 >>> May 20 14:17:21 gerlinda vmunix: [<c101c500>] ? >>> do_sched_setscheduler+0x90/0xa0May 20 14:17:21 gerlinda vmunix: >>> [<c11c0883>] ? schedule+0x203/0x3c0 >>> May 20 14:17:21 gerlinda vmunix: [<cc818109>] ? pccardd+0x219/0x470 >>> [pcmcia_core] >>> May 20 14:17:21 gerlinda vmunix: [<c11c095a>] ? schedule+0x2da/0x3c0 >>> May 20 14:17:21 gerlinda vmunix: [<cc817ef0>] ? pccardd+0x0/0x470 >>> [pcmcia_core]May 20 14:17:21 gerlinda vmunix: [<c1035124>] ? >>> kthread+0x74/0x80 >>> May 20 14:17:21 gerlinda vmunix: [<c10350b0>] ? kthread+0x0/0x80 >>> May 20 14:17:21 gerlinda vmunix: [<c10030f6>] ? >>> kernel_thread_helper+0x6/0x10 >>> May 20 14:17:21 gerlinda vmunix: ---[ end trace 256ec3e16d1d0f46 ]--- >>> >>> >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> Please read the FAQ at http://www.tux.org/lkml/ >>> >>> >>> >> maybe this is similar: >> >> https://bugzilla.kernel.org/show_bug.cgi?id=16015 >> >> Justin P. Mattock >> > No, it's different. The bug that I have is a code logic error, the > function pccard_validate_cis is called when it shouldn't be. > > Mikulas > > ahh!! I see. Justin P. Mattock ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PCMCIA regression 2010-05-25 20:25 PCMCIA regression Mikulas Patocka 2010-05-26 7:14 ` Justin P. Mattock @ 2010-05-26 11:35 ` Dominik Brodowski [not found] ` <20100602143822.GA11506@isilmar-3.linta.de> 1 sibling, 1 reply; 7+ messages in thread From: Dominik Brodowski @ 2010-05-26 11:35 UTC (permalink / raw) To: Mikulas Patocka; +Cc: linux-kernel Hey, On Tue, May 25, 2010 at 04:25:21PM -0400, Mikulas Patocka wrote: > The commit a8408c17d0038b76a83affb1b56dc18fa1e7ed86 in Linux 2.6.34-rc6 > broke pcmcia for me. I use 3c574 network card in yenta socket on Armada > 7400 laptop. My distribution is Debian lenny. > > Reverting the test for "s->functions" in pccard_validate_cis makes the > network card work again. Does this warning appear during reume, or during some other "special" use case? Also, does commit cc83b08fc791045ac197e6f4a030599bcd7100c5 solve this issue? If not: Could you enable dynamic debug logging via # mount debugfs mount none -t debugfs /sys/kernel/debug/ # enable debug echo "module pcmcia +p" > /sys/kernel/debug/dynamic_debug/control echo "module pcmcia_core +p" > /sys/kernel/debug/dynamic_debug/control echo "module yenta_socket +p" > /sys/kernel/debug/dynamic_debug/control and send me the resulting log (which may be looong). Thanks, Dominik ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20100602143822.GA11506@isilmar-3.linta.de>]
* Another PCMCIA regression [not found] ` <20100602143822.GA11506@isilmar-3.linta.de> @ 2010-06-14 17:41 ` Mikulas Patocka 2010-06-19 12:36 ` Dominik Brodowski 0 siblings, 1 reply; 7+ messages in thread From: Mikulas Patocka @ 2010-06-14 17:41 UTC (permalink / raw) To: Dominik Brodowski; +Cc: linux-kernel On Wed, 2 Jun 2010, Dominik Brodowski wrote: > Mikulas, > > On Wed, May 26, 2010 at 01:35:15PM +0200, Dominik Brodowski wrote: > > On Tue, May 25, 2010 at 04:25:21PM -0400, Mikulas Patocka wrote: > > > The commit a8408c17d0038b76a83affb1b56dc18fa1e7ed86 in Linux 2.6.34-rc6 > > > broke pcmcia for me. I use 3c574 network card in yenta socket on Armada > > > 7400 laptop. My distribution is Debian lenny. > > > > > > Reverting the test for "s->functions" in pccard_validate_cis makes the > > > network card work again. > > > > Does this warning appear during reume, or during some other "special" use > > case? Also, does commit cc83b08fc791045ac197e6f4a030599bcd7100c5 solve this > > issue? If not: Could you enable dynamic debug logging via > > > > # mount debugfs > > mount none -t debugfs /sys/kernel/debug/ > > > > # enable debug > > echo "module pcmcia +p" > /sys/kernel/debug/dynamic_debug/control > > echo "module pcmcia_core +p" > /sys/kernel/debug/dynamic_debug/control > > echo "module yenta_socket +p" > /sys/kernel/debug/dynamic_debug/control > > > > and send me the resulting log (which may be looong). > > any update on this? > > Thanks & best wishes, > > Dominik Hi That WARN_ON() bug is fixed in 2.6.35-rc3, but there is another bug, also introduced in 2.6.34-rc6 in "pcmcia: pcmcia_dev_present bugfix" That patch changes bit field to atomic_t, it wouldn't be problematic, but it also adds one line "atomic_set(&socket->present, 0);" to pcmcia_bus_add_socket which causes nonworking eth0. The symptoms are: eth0 is present, but can't be activated with "ifconfig eth0 up". The test "pcmcia_dev_present(link)" in drivers/net/pcmcia/3c574_cs.c:el3_open is failing. This bug happens only after system boot, if I unload and reinsert the modules manually, it doesn't happen. I'm here sending the patch that reverts the change and fixes the bug (I don't know why, I found it experimentally). Mikulas --- drivers/pcmcia/ds.c | 2 -- 1 file changed, 2 deletions(-) Index: linux-2.6.35-rc3-fast/drivers/pcmcia/ds.c =================================================================== --- linux-2.6.35-rc3-fast.orig/drivers/pcmcia/ds.c 2010-06-13 10:13:37.000000000 +0200 +++ linux-2.6.35-rc3-fast/drivers/pcmcia/ds.c 2010-06-14 19:14:08.000000000 +0200 @@ -1364,8 +1364,6 @@ static int __devinit pcmcia_bus_add_sock return ret; } - atomic_set(&socket->present, 0); - return 0; } ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Another PCMCIA regression 2010-06-14 17:41 ` Another " Mikulas Patocka @ 2010-06-19 12:36 ` Dominik Brodowski 0 siblings, 0 replies; 7+ messages in thread From: Dominik Brodowski @ 2010-06-19 12:36 UTC (permalink / raw) To: Mikulas Patocka; +Cc: linux-kernel Mikulas, many thanks for tracking down this issue. Does the following patch (instead of the one you provided) help, too? Thanks & best, Dominik From: Dominik Brodowski <linux@dominikbrodowski.net> Date: Sat, 19 Jun 2010 14:33:56 +0200 Subject: [PATCH] pcmcia: do not initialize the present flag too late. The "present" flag was initialized too late -- possibly, a card was already registered at this time, so re-setting the flag to 0 caused pcmcia_dev_present() to fail. Reported-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net> diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c index 9fc3398..eac9614 100644 --- a/drivers/pcmcia/ds.c +++ b/drivers/pcmcia/ds.c @@ -1356,6 +1356,7 @@ static int __devinit pcmcia_bus_add_socket(struct device *dev, INIT_LIST_HEAD(&socket->devices_list); memset(&socket->pcmcia_state, 0, sizeof(u8)); socket->device_count = 0; + atomic_set(&socket->present, 0); ret = pccard_register_pcmcia(socket, &pcmcia_bus_callback); if (ret) { @@ -1364,8 +1365,6 @@ static int __devinit pcmcia_bus_add_socket(struct device *dev, return ret; } - atomic_set(&socket->present, 0); - return 0; } ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-06-19 12:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-25 20:25 PCMCIA regression Mikulas Patocka
2010-05-26 7:14 ` Justin P. Mattock
2010-05-26 11:27 ` Mikulas Patocka
2010-05-26 13:29 ` Justin P. Mattock
2010-05-26 11:35 ` Dominik Brodowski
[not found] ` <20100602143822.GA11506@isilmar-3.linta.de>
2010-06-14 17:41 ` Another " Mikulas Patocka
2010-06-19 12:36 ` Dominik Brodowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox