From: Ingo Molnar <mingo@elte.hu>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Divyesh Shah <dpshah@google.com>
Subject: Re: [PATCH] cfq-iosched: Fixed boot warning with BLK_CGROUP=y and CFQ_GROUP_IOSCHED=n
Date: Sun, 20 Jun 2010 10:10:16 +0200 [thread overview]
Message-ID: <20100620081016.GA5365@elte.hu> (raw)
In-Reply-To: <20100618143947.GA8431@redhat.com>
* Vivek Goyal <vgoyal@redhat.com> wrote:
> Hi Jens,
>
> Few days back Ingo noticed a CFQ boot time warning. This patch fixes it.
Hm, have you tested it? This bit:
> +++ linux-2.6/block/cfq.h 2010-06-18 09:41:23.256220395 -0400
> +static inline void cfq_blkiocg_update_completion_stats(struct blkio_group *blkg, uint64_t start_time, uint64_t io_start_time, bool direction, bool sync)
> +{
> + cfq_blkiocg_update_completion_stats(blkg, start_time, io_start_time,
> + direction, sync);
> +}
is an inline function calling itself.
Ingo
next prev parent reply other threads:[~2010-06-20 8:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 14:39 [PATCH] cfq-iosched: Fixed boot warning with BLK_CGROUP=y and CFQ_GROUP_IOSCHED=n Vivek Goyal
2010-06-18 17:58 ` Jens Axboe
2010-06-19 0:35 ` Divyesh Shah
2010-06-20 8:10 ` Ingo Molnar [this message]
2010-06-20 22:56 ` Vivek Goyal
2010-06-21 7:05 ` Ingo Molnar
2010-06-21 14:50 ` Vivek Goyal
2010-06-21 15:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100620081016.GA5365@elte.hu \
--to=mingo@elte.hu \
--cc=axboe@kernel.dk \
--cc=dpshah@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox