public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Divyesh Shah <dpshah@google.com>
Subject: Re: [PATCH] cfq-iosched: Fixed boot warning with BLK_CGROUP=y and CFQ_GROUP_IOSCHED=n
Date: Mon, 21 Jun 2010 10:50:16 -0400	[thread overview]
Message-ID: <20100621145016.GA4259@redhat.com> (raw)
In-Reply-To: <20100621070517.GA31535@elte.hu>

On Mon, Jun 21, 2010 at 09:05:17AM +0200, Ingo Molnar wrote:
> 
> * Vivek Goyal <vgoyal@redhat.com> wrote:
> 
> > On Sun, Jun 20, 2010 at 10:10:16AM +0200, Ingo Molnar wrote:
> > > 
> > > * Vivek Goyal <vgoyal@redhat.com> wrote:
> > > 
> > > > Hi Jens,
> > > > 
> > > > Few days back Ingo noticed a CFQ boot time warning. This patch fixes it.
> > > 
> > > Hm, have you tested it? This bit:
> > 
> > I did compile and boot testing. Booted with CFQ_GROUP_IOSCHED=n to make
> > sure warning seen by you is gone. [...]
> 
> It was not a build warning, it was a build failure. (Even if it built the 
> recursion would cause a crash on bootup.) Will try your newer patch too.

I think compiler is doing some optimizations. On my system, it just
compiles fine and even boots fine. But when I introduce a trace_printk(),
statement in the function, then compilation is fine but system hangs
during boot.

I am using gcc version 4.4.4 20100503.

Thanks
Vivek

  reply	other threads:[~2010-06-21 14:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-18 14:39 [PATCH] cfq-iosched: Fixed boot warning with BLK_CGROUP=y and CFQ_GROUP_IOSCHED=n Vivek Goyal
2010-06-18 17:58 ` Jens Axboe
2010-06-19  0:35 ` Divyesh Shah
2010-06-20  8:10 ` Ingo Molnar
2010-06-20 22:56   ` Vivek Goyal
2010-06-21  7:05     ` Ingo Molnar
2010-06-21 14:50       ` Vivek Goyal [this message]
2010-06-21 15:16       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100621145016.GA4259@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dpshah@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox