From: Don Zickus <dzickus@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Prarit Bhargava <prarit@redhat.com>,
linux-kernel@vger.kernel.org,
Randy Dunlap <randy.dunlap@oracle.com>,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] Add TAINT_HARDWARE_UNSUPPORTED flag
Date: Mon, 21 Jun 2010 16:46:46 -0400 [thread overview]
Message-ID: <20100621204646.GJ3217@redhat.com> (raw)
In-Reply-To: <20100621130008.d3dc01a8.akpm@linux-foundation.org>
On Mon, Jun 21, 2010 at 01:00:08PM -0700, Andrew Morton wrote:
> > Internally here that is how we planned on using the flag. We weren't sure
> > if upstream would accept that piece or not, so we started with the flag
> > for now to at least reserve the bit.
> >
> > But I can see your point about the other printk being a little
> > user-hostile if someone forgot to call the wrapper function.
> >
> > I can respin with the wrapper function (Prarit is on vacation)
>
> Not telling the user _which_ hardware is causing the problem is daft.
>
> > or go with
> > Alan's idea of just reserving the upper few bits.
>
> um. Given that the vendor needs to patch the individual drivers to
> indicate ther unsupported status, why not just patch in the taint
> changes as well?
Well we wanted to secure a bit flag first, so we don't bite ourselves later and
have to change the userspace tools.
Cheers,
Don
next prev parent reply other threads:[~2010-06-21 20:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 13:54 [PATCH] Add TAINT_HARDWARE_UNSUPPORTED flag Prarit Bhargava
2010-06-17 16:13 ` Randy Dunlap
2010-06-17 19:54 ` Prarit Bhargava
2010-06-17 20:28 ` Randy Dunlap
2010-06-21 19:21 ` Andrew Morton
2010-06-21 19:45 ` Don Zickus
2010-06-21 20:00 ` Andrew Morton
2010-06-21 20:46 ` Don Zickus [this message]
2010-06-22 15:34 ` [PATCH v3] " Don Zickus
2010-06-22 15:48 ` Alan Cox
2010-06-22 16:38 ` Matthew Garrett
2010-06-22 16:57 ` Alan Cox
2010-06-22 17:04 ` Matthew Garrett
2010-06-23 3:06 ` Paul Mundt
2010-06-23 3:30 ` Matthew Garrett
2010-06-23 20:00 ` Don Zickus
2010-06-22 18:58 ` [PATCH v4] " Don Zickus
2010-07-06 20:33 ` Don Zickus
2010-07-06 22:18 ` Alan Cox
2010-06-19 8:40 ` [PATCH] " Andi Kleen
2010-06-19 9:30 ` Alan Cox
2010-06-21 13:26 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100621204646.GJ3217@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).