[stable] please consider drm radeon kms agp release

[stable] please consider drm radeon kms agp release

[Martin Steigerwald]

[-- Attachment #1.1: Type: Text/Plain, Size: 512 bytes --]


Hi Greg, hi stable kernel team,

Please consider the attached patch from Jérôme Glisse. It fixes drm radeon 
KMS after coming out from a snapshot cycle [1] - no matter whether I use 
userspace software suspend or TuxOnIce.

Verified on my notebook ThinkPad T42 and by cedric, the reporter of above 
bug.

Thanks.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=15969#c14

Ciao,
-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7

[-- Attachment #1.2: 0001-drm-radeon-kms-release-AGP-bridge-at-suspend.patch --]
[-- Type: text/x-patch, Size: 2043 bytes --]

From bc19ff2e0bff31523af06bc089b71b4f46478837 Mon Sep 17 00:00:00 2001
From: Jerome Glisse <jglisse@redhat.com>
Date: Fri, 21 May 2010 14:19:07 +0200
Subject: [PATCH] drm/radeon/kms: release AGP bridge at suspend

I think it's good to release the AGP bridge at suspend
and reacquire it at resume. Also fix :
https://bugzilla.kernel.org/show_bug.cgi?id=15969

Signed-off-by: Jerome Glisse <jglisse@redhat.com>
---
 drivers/gpu/drm/radeon/radeon.h        |    1 +
 drivers/gpu/drm/radeon/radeon_agp.c    |    5 +++++
 drivers/gpu/drm/radeon/radeon_device.c |    2 ++
 3 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h
index 034218c..4c7204a 100644
--- a/drivers/gpu/drm/radeon/radeon.h
+++ b/drivers/gpu/drm/radeon/radeon.h
@@ -566,6 +566,7 @@ typedef int (*radeon_packet3_check_t)(struct radeon_cs_parser *p,
  */
 int radeon_agp_init(struct radeon_device *rdev);
 void radeon_agp_resume(struct radeon_device *rdev);
+void radeon_agp_suspend(struct radeon_device *rdev);
 void radeon_agp_fini(struct radeon_device *rdev);
 
 
diff --git a/drivers/gpu/drm/radeon/radeon_agp.c b/drivers/gpu/drm/radeon/radeon_agp.c
index 28e473f..f40dfb7 100644
--- a/drivers/gpu/drm/radeon/radeon_agp.c
+++ b/drivers/gpu/drm/radeon/radeon_agp.c
@@ -270,3 +270,8 @@ void radeon_agp_fini(struct radeon_device *rdev)
 	}
 #endif
 }
+
+void radeon_agp_suspend(struct radeon_device *rdev)
+{
+	radeon_agp_fini(rdev);
+}
diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
index 7b629e3..ed6a724 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -748,6 +748,8 @@ int radeon_suspend_kms(struct drm_device *dev, pm_message_t state)
 	/* evict remaining vram memory */
 	radeon_bo_evict_vram(rdev);
 
+	radeon_agp_suspend(rdev);
+
 	pci_save_state(dev->pdev);
 	if (state.event == PM_EVENT_SUSPEND) {
 		/* Shut down the device */
-- 
1.7.0.1


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [stable] please consider drm radeon kms agp release

[Greg KH]

On Mon, May 31, 2010 at 04:42:41PM +0200, Martin Steigerwald wrote:
> 
> Hi Greg, hi stable kernel team,
> 
> Please consider the attached patch from Jérôme Glisse. It fixes drm radeon 
> KMS after coming out from a snapshot cycle [1] - no matter whether I use 
> userspace software suspend or TuxOnIce.
> 
> Verified on my notebook ThinkPad T42 and by cedric, the reporter of above 
> bug.

Which stable kernel release do you want to see this patch in?  .27, .32,
.33, or .34?  Yeah, there's a lot active at the moment :(

thanks,

greg k-h

Re: [stable] please consider drm radeon kms agp release

[Jerome Glisse]

On Mon, May 31, 2010 at 10:02:34AM -0700, Greg KH wrote:
> On Mon, May 31, 2010 at 04:42:41PM +0200, Martin Steigerwald wrote:
> > 
> > Hi Greg, hi stable kernel team,
> > 
> > Please consider the attached patch from Jérôme Glisse. It fixes drm radeon 
> > KMS after coming out from a snapshot cycle [1] - no matter whether I use 
> > userspace software suspend or TuxOnIce.
> > 
> > Verified on my notebook ThinkPad T42 and by cedric, the reporter of above 
> > bug.
> 
> Which stable kernel release do you want to see this patch in?  .27, .32,
> .33, or .34?  Yeah, there's a lot active at the moment :(
> 
> thanks,
> 
> greg k-h

2.6.34 sorry if i wasn't clear when ccing stable while sending patch for
2.6.35.

Cheers,
Jerome

Re: [stable] please consider drm radeon kms agp release

[Martin Steigerwald]

[-- Attachment #1: Type: Text/Plain, Size: 1045 bytes --]

Am Montag 31 Mai 2010 schrieb Jerome Glisse:
> On Mon, May 31, 2010 at 10:02:34AM -0700, Greg KH wrote:
> > On Mon, May 31, 2010 at 04:42:41PM +0200, Martin Steigerwald wrote:
> > > Hi Greg, hi stable kernel team,
> > > 
> > > Please consider the attached patch from Jérôme Glisse. It fixes drm
> > > radeon KMS after coming out from a snapshot cycle [1] - no matter
> > > whether I use userspace software suspend or TuxOnIce.
> > > 
> > > Verified on my notebook ThinkPad T42 and by cedric, the reporter of
> > > above bug.
> > 
> > Which stable kernel release do you want to see this patch in?  .27,
> > .32, .33, or .34?  Yeah, there's a lot active at the moment :(
> > 
> > thanks,
> > 
> > greg k-h
> 
> 2.6.34 sorry if i wasn't clear when ccing stable while sending patch
> for 2.6.35.

Yeah forgot to mention it also, in 2.6.33 it works. In 2.6.35 its fixed. So 
it applies for 2.6.34.

Thanks,
-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [stable] please consider drm radeon kms agp release

[Greg KH]

On Mon, May 31, 2010 at 11:56:26PM +0200, Martin Steigerwald wrote:
> Am Montag 31 Mai 2010 schrieb Jerome Glisse:
> > On Mon, May 31, 2010 at 10:02:34AM -0700, Greg KH wrote:
> > > On Mon, May 31, 2010 at 04:42:41PM +0200, Martin Steigerwald wrote:
> > > > Hi Greg, hi stable kernel team,
> > > > 
> > > > Please consider the attached patch from Jérôme Glisse. It fixes drm
> > > > radeon KMS after coming out from a snapshot cycle [1] - no matter
> > > > whether I use userspace software suspend or TuxOnIce.
> > > > 
> > > > Verified on my notebook ThinkPad T42 and by cedric, the reporter of
> > > > above bug.
> > > 
> > > Which stable kernel release do you want to see this patch in?  .27,
> > > .32, .33, or .34?  Yeah, there's a lot active at the moment :(
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > 2.6.34 sorry if i wasn't clear when ccing stable while sending patch
> > for 2.6.35.
> 
> Yeah forgot to mention it also, in 2.6.33 it works. In 2.6.35 its fixed. So 
> it applies for 2.6.34.

All queued up now, thanks.

greg k-h