From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
David Miller <davem@davemloft.net>
Subject: [PULL] virtio fixes
Date: Wed, 23 Jun 2010 22:50:24 +0930 [thread overview]
Message-ID: <201006232250.25564.rusty@rustcorp.com.au> (raw)
(There are two net fixes which depend on this which will go via DaveM, so
please pull soon).
The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
Linus Torvalds (1):
Linux 2.6.35-rc3
are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6.git virtio
Michael S. Tsirkin (2):
virtio: return ENOMEM on out of memory
virtio-pci: disable msi at startup
drivers/pci/pci.c | 1 +
drivers/virtio/virtio_pci.c | 3 +++
drivers/virtio/virtio_ring.c | 2 +-
3 files changed, 5 insertions(+), 1 deletions(-)
commit 686d363786a53ed28ee875b84ef24e6d5126ef6f
Author: Michael S. Tsirkin <mst@redhat.com>
Date: Thu Jun 10 18:16:11 2010 +0300
virtio: return ENOMEM on out of memory
add_buf returns ring size on out of memory,
this is not what devices expect.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org # .34.x
drivers/virtio/virtio_ring.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
commit b03214d559471359e2a85ae256686381d0672f29
Author: Michael S. Tsirkin <mst@redhat.com>
Date: Wed Jun 23 22:49:06 2010 -0600
virtio-pci: disable msi at startup
virtio-pci resets the device at startup by writing to the status
register, but this does not clear the pci config space,
specifically msi enable status which affects register
layout.
This breaks things like kdump when they try to use e.g. virtio-blk.
Fix by forcing msi off at startup. Since pci.c already has
a routine to do this, we export and use it instead of duplicating code.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org
drivers/pci/pci.c | 1 +
drivers/virtio/virtio_pci.c | 3 +++
2 files changed, 4 insertions(+), 0 deletions(-)
next reply other threads:[~2010-06-23 13:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 13:20 Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-10 13:18 [PULL] virtio: fixes Michael S. Tsirkin
2019-04-10 16:50 ` pr-tracker-bot
2019-02-06 19:32 Michael S. Tsirkin
2019-02-07 8:10 ` pr-tracker-bot
2014-09-16 1:04 [PULL] virtio fixes Rusty Russell
2013-05-22 0:55 Rusty Russell
2013-04-01 23:08 Rusty Russell
2011-04-21 13:31 Rusty Russell
2011-02-08 21:53 Rusty Russell
2009-10-19 2:31 Rusty Russell
2009-10-21 23:31 ` Linus Torvalds
2009-10-22 6:13 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006232250.25564.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox