Re: [patch 02/52] fs: fix superblock iteration race

Al Viro
2010-06-30T12:51:14Z

On Tue, Jun 29, 2010 at 10:58:14AM -0700, Linus Torvalds wrote:
> On Tue, Jun 29, 2010 at 10:52 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Look for "2.6.35-rc3 oops trying to suspend" on lkml, for example. No
> > guarantee that it's the same thing, but it's "iterate_supers()"
> > getting an oops [..]
>
> Also, "Oops during closedown with 2.6.35-rc3-git3" is an
> iterate_supers oops (in the jpg) and Chris says it's repeatable for
> him.
>
> Chris - you could try testing current -git now that I've merged Nick's
> patch. It's commit 57439f878af ("fs: fix superblock iteration race"),
> and I just pushed it out (so it might take a few minutes to mirror out
> to the public git trees, but it should be there shortly).

ACK. I've several cleanups on top of that, but that's not a .35 fodder.
I'll put them into for-next tonight. But yes, the hole caught by
Nick is definitely real and very likely to be responsible for all that
pile of reports. Mea culpa.