Re: [GIT PULL] block/io bits for 2.6.35-rc

Jens Axboe
2010-06-10T16:59:57Z

On 2010-06-10 18:40, Christoph Hellwig wrote:
> On Thu, Jun 10, 2010 at 06:25:17PM +0200, Jens Axboe wrote:
>> I agree, it's late and it makes me nervous too. I had them cook for
>> a day, didn't see any problems. And Christoph would not send it in
>> unless it passes at least xfs qa, which is what found the problems
>> last time (the ones we reverted).
>>
>> It's fixing a regression where umount takes a LONG time if you have
>> a lot of dirty inodes, since it basically degenerates to a data
>> integrity writeback instead of a simple WB_SYNC_NONE. If it wasn't
>> fixing a nasty regression (the distros are all wanting a real fix
>> for this, it's a user problem), I would not be submitting this code
>> at this point in time.
>
> Maybe give it a bit more beating in linux-next and send it off to Linus
> once he's back from his vacation?

We can do that. Linus, I'll split split off the writeback parts and send
you a new pull request.

--
Jens Axboe