From: Oleg Nesterov <oleg@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Darren Hart <dvhltc@us.ibm.com>, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Andreas Schwab <schwab@redhat.com>, Danny Feng <dfeng@redhat.com>,
Jakub Jelinek <jakub@redhat.com>,
linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: Q: sys_futex() && timespec_valid()
Date: Mon, 28 Jun 2010 15:58:25 +0200 [thread overview]
Message-ID: <20100628135825.GA17681@redhat.com> (raw)
In-Reply-To: <2054433814.959851277495348646.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
On 06/25, Ulrich Drepper wrote:
>
> ----- "Darren Hart" <dvhltc@us.ibm.com> wrote:
> > Unless there is some good reason to object to breaking the API that I
> > am missing, I don't mind changing it to -ETIMEDOUT (although -EINVAL
> > seems more intuitive to me).
>
> It's only not intuitive because Oleg misrepresented or at least didn't
> describe the issue.
> ...
> It pure and simply
> a bug fix.
Because personally I disagree that sys_futex()->timespec_valid() is buggy.
I repeated this many times during the previous discussion. I didn't even
try to judge if it is really right or not, because my opinion doesn't matter
at all here.
But it is unfair (imho) to state this code is buggy. The code is correct
even if it does not match your expectations, it works as expected/designed.
And, sys_futex() does this since 2006 iirc.
Honestly, it looks a bit strange to me that you blame the correct code,
and at the same time you ignore the test-case which hangs because the
kernel returns -EFAULT saying that this is the caller's problem.
Oleg.
next prev parent reply other threads:[~2010-06-28 14:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 19:20 Q: sys_futex() && timespec_valid() Oleg Nesterov
2010-06-25 19:42 ` Darren Hart
2010-06-25 19:49 ` Ulrich Drepper
2010-06-25 20:11 ` Thomas Gleixner
2010-06-28 13:58 ` Oleg Nesterov [this message]
2010-06-28 14:37 ` Jakub Jelinek
2010-06-28 15:02 ` Oleg Nesterov
2010-06-25 19:56 ` Mathieu Desnoyers
2010-06-25 19:59 ` Thomas Gleixner
2010-06-25 20:04 ` Ulrich Drepper
2010-06-25 20:25 ` Thomas Gleixner
2010-06-28 15:15 ` Linus Torvalds
2010-06-28 15:29 ` Andreas Schwab
2010-06-28 15:33 ` Thomas Gleixner
2010-06-28 16:04 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628135825.GA17681@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dfeng@redhat.com \
--cc=drepper@redhat.com \
--cc=dvhltc@us.ibm.com \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=schwab@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox