Re: [PATCH] memory hotplug disable boot option

Nathan Fontenot
2010-06-25T16:00:14Z

On 06/25/2010 10:28 AM, Andi Kleen wrote:
>> Yes, this would work to reduce the number of memory sections created. The reason
>
> Note it could be done on the sysfs interface level too, e.g. have one
> entry that gets a bitmap as input/output.

This was sort of the idea I was thinking of for a flat representation in sysfs.
Instead of creating all of the directories for each memory section, have a single
file for the memory section attributes. For example, an 'online' file. Users
could read the file to get online memory section numbers and write to it to
online a specific memory section.

>
>> I have not gone this route is that increasing the memory section size would
>> break DLPAR memory add and remove for powerpc pseries.
>
> How would it break it?

For the powerpc/pseries hardware memory is assigned in LMB size chunks. If the
memory section size is larger than the LMB size then DLPAR remove would have
to hotplug remove more memory than required to DLPAR remove the memory. For
DLPAR memory add, we would fail because we could not hotplug add the larger
memory section since that much memory had not actually been given to the
machine.

>
> But aren't you breaking this anyways by disabling the sysfs entries?!?

This is meant more for allowing people to bot systems without the long boot
times (as mentioned before 8+ hours for a 2TB system) even if it means they
will not be able to memory hotplug or memory DLPAR.

-Nathan