Re: [PATCH] memory hotplug disable boot option

Eric W. Biederman
2010-06-28T19:43:31Z

Andi Kleen <andi@firstfloor.org> writes:

>> I have a prototype patch sitting around somewhere. I think ultimately
>> it makes sense to do something like extN's htree directory structure
>> in sysfs. I wanted to get the tagged sysfs support in before I worked
>> on scalability because that slightly changes the requirements.
>>
>> Improving the scalability here is certainly worth doing, but I am slightly
>> concerned there is something else algorithmically wrong if this is still
>> going to take 33 minutes to boot with 2TB.
>
> I'm don't think thousands of entries in sysfs is really a good idea. Even if you fix
> the the insert algorithm issues a simple ls will still be very slow and there
> will be likely other issues too. And nobody can claim that's a good interface.

Yes. I am much more interested in fixing lookup and stat performance,
if people only look at insert performance it is a bit of a joke.

That said there are cases of people using a lot of network virtual
network devices that are essentially sane that push sysfs.

This is only the second or third time sysfs scalability has come up
this year. So at some level I think it is sane to fix sysfs regardless
of what we do with memory hotplug.

Ensuring that our insert times are O(logN) for insert, O(N) for readdir,
O(logN) for lookup and O(log1) for stat, seems useful if we can do it
without other complications.

Eric