From: Arnd Bergmann <arnd@arndb.de>
To: Tony Luck <tony.luck@intel.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
John Kacur <jkacur@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] tty: avoid recursive BTM in pty_close
Date: Mon, 28 Jun 2010 21:03:58 +0200 [thread overview]
Message-ID: <201006282103.58269.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTikMuR-KLBnYN5Utbz2MV3WRLWLYg3s4QcSkQjYd@mail.gmail.com>
On Monday 28 June 2010 19:17:39 Tony Luck wrote:
> On Fri, Jun 18, 2010 at 11:35 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> >> Call Trace:
> >> [<a0000001000159d0>] show_stack+0x50/0xa0
> >> [<a00000010090f270>] dump_stack+0x30/0x50
> >> [<a00000010008e2c0>] warn_slowpath_common+0xc0/0x120
> >> [<a00000010008e360>] warn_slowpath_null+0x40/0x60
> >> [<a00000010053eb40>] tty_open+0x160/0xc60
> >> [<a0000001001af9b0>] chrdev_open+0x310/0x360
> >> [<a0000001001a58b0>] __dentry_open+0x350/0x680
> >> [<a0000001001a5d80>] nameidata_to_filp+0x80/0xc0
> >> [<a0000001001bfee0>] finish_open+0x160/0x380
> >> [<a0000001001c0cc0>] do_last+0xbc0/0xce0
> >> [<a0000001001c5270>] do_filp_open+0x2f0/0xb40
> >> [<a0000001001a5290>] do_sys_open+0x90/0x200
> >> [<a0000001001a54d0>] sys_open+0x50/0x80
> >> [<a000000100b907e0>] kernel_init+0x340/0x420
> >> [<a000000100013c10>] kernel_thread_helper+0x30/0x60
> >> [<a00000010000a0c0>] start_kernel_thread+0x20/0x40
> >
> > Ok, this is the same one you reported at first. I forgot to
> > mention that the other patch I sent as a reply to your report
> > is still needed and not yet in -next since I'm trying to
> > sort through the other BKL removal patches now.
> > This instance of the WARN_ON is completely harmless though,
> > you could consider this one a false positive.
>
> Quick status check. I'm still seeing these messages in next-20100628.
> Are you still working on a fix?
I got distracted and it wasn't on my list of pressing issues because
this particular warning is harmless. I should get the base bkl series
into -next to fix this.
For the other issue (garbled output), I'm not sure how to proceed.
Alan didn't like the easy workaround of reverting the commit that
introduced it and the fix that Alan suggested only solved the
problem partially as far as I can tell.
Arnd
prev parent reply other threads:[~2010-06-28 19:04 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 20:59 [PATCH v3 00/10] BKL conversion in tty layer Arnd Bergmann
2010-05-15 20:59 ` [PATCH 01/10] tty: replace BKL with a new tty_lock Arnd Bergmann
2010-05-15 20:59 ` [PATCH 02/10] tty: never hold BTM while getting tty_mutex Arnd Bergmann
2010-05-15 20:59 ` [PATCH 03/10] tty: fix console_sem lock order Arnd Bergmann
2010-05-15 20:59 ` [PATCH 04/10] cdc-acm: remove dead code Arnd Bergmann
2010-05-15 20:59 ` [PATCH 05/10] tty: introduce wait_event_interruptible_tty Arnd Bergmann
2010-05-15 20:59 ` [PATCH 06/10] tty: annotate tty_write_lock Arnd Bergmann
2010-05-15 20:59 ` [PATCH 07/10] tty: reorder ldisc locking Arnd Bergmann
2010-05-15 20:59 ` [PATCH 08/10] tty: untangle locking of wait_until_sent Arnd Bergmann
2010-05-16 3:12 ` Daniel K.
2010-05-15 20:59 ` [PATCH 09/10] tty: remove tty_lock_nested Arnd Bergmann
2010-05-15 20:59 ` [PATCH 10/10] tty: implement BTM as mutex instead of BKL Arnd Bergmann
2010-05-16 3:33 ` Daniel K.
2010-05-16 12:58 ` Arnd Bergmann
2010-05-17 13:41 ` [PATCH v3 00/10] BKL conversion in tty layer Alan Cox
2010-05-17 15:30 ` Greg KH
2010-05-17 18:30 ` Arnd Bergmann
2010-05-18 4:27 ` Greg KH
2010-05-18 21:52 ` Arnd Bergmann
2010-05-19 1:50 ` Greg KH
2010-05-22 13:54 ` Arnd Bergmann
2010-05-17 18:49 ` Arnd Bergmann
2010-06-17 19:13 ` Tony Luck
2010-06-17 19:40 ` Arnd Bergmann
2010-06-17 20:15 ` Tony Luck
2010-06-17 21:48 ` Arnd Bergmann
2010-06-17 22:09 ` Frederic Weisbecker
2010-06-18 12:58 ` [PATCH] tty: avoid recursive BTM in pty_close Arnd Bergmann
2010-06-18 16:21 ` Alan Cox
2010-06-18 16:52 ` Tony Luck
2010-06-18 18:35 ` Arnd Bergmann
2010-06-18 20:25 ` Tony Luck
2010-06-19 12:32 ` Arnd Bergmann
2010-06-19 20:29 ` [PATCH] serial: revert "Use block_til_ready helper" Arnd Bergmann
2010-06-19 21:57 ` Alan Cox
2010-06-20 20:54 ` Arnd Bergmann
2010-06-21 14:13 ` Alan Cox
2010-06-21 20:57 ` Arnd Bergmann
2010-06-21 20:58 ` Arnd Bergmann
2010-06-21 17:11 ` Tony Luck
2010-06-22 23:01 ` Greg KH
2010-06-28 17:17 ` [PATCH] tty: avoid recursive BTM in pty_close Tony Luck
2010-06-28 19:03 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006282103.58269.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox