Re: [patch 50/52] mm: implement per-zone shrinker

Andi Kleen
2010-06-24T10:06:53Z

npiggin@suse.de writes:

> Allow the shrinker to do per-zone shrinking. This means it is called for
> each zone scanned. The shrinker is now completely responsible for calculating
> and batching (given helpers), which provides better flexibility.

Beyond the scope of this patch, but at some point this probably needs
to be even more fine grained. With large number of cores/threads in
each socket a "zone" is actually shared by quite a large number
of CPUs now and this can cause problems.

> +void shrinker_add_scan(unsigned long *dst,
> + unsigned long scanned, unsigned long total,
> + unsigned long objects, unsigned int ratio)
> +{
> + unsigned long long delta;
> +
> + delta = (unsigned long long)scanned * objects * ratio;
> + do_div(delta, total + 1);
> + delta /= (128ULL / 4ULL);

Again I object to the magic numbers ...

> + nr += shrink_slab(zone, 1, 1, 1, GFP_KERNEL);
> + if (nr >= 10)
> + goto again;

And here.

Overall it seems good, but I have not read all the shrinker callback
changes in all subsystems.
-Andi

--
ak@linux.intel.com -- Speaking for myself only.