From: Kulikov Vasiliy <segooon@gmail.com>
To: Dan Carpenter <error27@gmail.com>,
Kernel Janitors <kernel-janitors@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/25] r852: remove casts from void*
Date: Tue, 29 Jun 2010 19:28:26 +0400 [thread overview]
Message-ID: <20100629152823.GA4268@shinshilla> (raw)
In-Reply-To: <20100629123850.GO19184@bicker>
> 1) The subjects are not helpful. This one should say something about
> "mtd" but it doesn't.
ok
> 2) These haven't been run through checkpatch.pl.
Sorry for dummy question, but shouldn't code style be consistent?
Somebody who will see old code and patched code will see one line with
wrong-style code then one line with ok then one with wrong etc.
Imho it's better to fix style in one big patch.
next prev parent reply other threads:[~2010-06-29 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 10:14 [PATCH 01/25] r852: remove casts from void* Kulikov Vasiliy
2010-06-29 12:42 ` Dan Carpenter
2010-06-29 12:56 ` walter harms
2010-06-29 15:28 ` Kulikov Vasiliy [this message]
2010-06-29 19:01 ` Dan Carpenter
2010-07-13 9:57 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629152823.GA4268@shinshilla \
--to=segooon@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox