From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Masami Hiramatsu <mhiramat@redhat.com>,
Mel Gorman <mel@csn.ul.ie>, Randy Dunlap <rdunlap@xenotime.net>,
Steven Rostedt <rostedt@goodmis.org>,
Roland McGrath <roland@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Christoph Hellwig <hch@infradead.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Oleg Nesterov <oleg@redhat.com>, Mark Wielaard <mjw@redhat.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Frank Ch. Eigler" <fche@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCHv6 2.6.35-rc3-tip 10/12] perf: Dont adjust symbols on name lookup
Date: Tue, 29 Jun 2010 23:23:42 +0530 [thread overview]
Message-ID: <20100629175342.GE23231@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100628135038.GA8902@ghostprotocols.net>
> >
> > perf: Dont adjust symbols on name lookup
> >
> > Adjusting symbols is not needed if we are searching by name even
> > if the symbols correspond to user space objects.
> > Infact if we adjust and search symbols by name, we get incorrect
> > results.
>
> I'll review this, but it would be nice to explain why we get incorrect
> results, as we may be just fixing a symptom of some other problem.
>
You are right. I removed this patch and still see no change in
behaviour. Earlier without this patch, I saw that perf report
would show a wrong function name(around 2.6.34-rc5 and I carried it
to 2.6.35-tip). However the number of events recorded would
correspond to the probed function.
Since I am seeing correct behaviour even without this patch, I
will drop this patch in the next posting of the patchset.
--
Thanks
Srikar
next prev parent reply other threads:[~2010-06-29 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 5:57 [PATCHv6 2.6.35-rc3-tip 0/12] Uprobes Patches: Srikar Dronamraju
2010-06-28 5:57 ` [PATCHv6 2.6.35-rc3-tip 1/12] mm: Move replace_page() / write_protect_page() to mm/memory.c Srikar Dronamraju
2010-06-28 5:58 ` [PATCHv6 2.6.35-rc3-tip 2/12] uprobes: Breakpoint insertion/removal in user space applications Srikar Dronamraju
2010-06-28 5:58 ` [PATCHv6 2.6.35-rc3-tip 3/12] uprobes: Slot allocation for Execution out of line(XOL) Srikar Dronamraju
2010-06-28 5:58 ` [PATCHv6 2.6.35-rc3-tip 4/12] uprobes: x86 specific functions for user space breakpointing Srikar Dronamraju
2010-06-28 5:58 ` [PATCHv6 2.6.35-rc3-tip 5/12] uprobes: Uprobes (un)registration and exception handling Srikar Dronamraju
2010-06-28 5:59 ` [PATCHv6 2.6.35-rc3-tip 6/12] uprobes: X86 support for Uprobes Srikar Dronamraju
2010-06-28 5:59 ` [PATCHv6 2.6.35-rc3-tip 7/12] uprobes: Uprobes Documentation Srikar Dronamraju
2010-06-28 5:59 ` [PATCHv6 2.6.35-rc3-tip 8/12] trace: Extract out common code for kprobes/uprobes traceevents Srikar Dronamraju
2010-06-28 12:22 ` Masami Hiramatsu
2010-06-28 5:59 ` [PATCHv6 2.6.35-rc3-tip 9/12] trace: uprobes trace_event interface Srikar Dronamraju
2010-06-28 5:59 ` [PATCHv6 2.6.35-rc3-tip 10/12] perf: Dont adjust symbols on name lookup Srikar Dronamraju
2010-06-28 13:50 ` Arnaldo Carvalho de Melo
2010-06-29 17:53 ` Srikar Dronamraju [this message]
2010-06-28 5:59 ` [PATCHv6 2.6.35-rc3-tip 11/12] perf: Re-Add make_absolute_path Srikar Dronamraju
2010-06-28 6:00 ` [PATCHv6 2.6.35-rc3-tip 12/12] perf: perf interface for uprobes Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629175342.GE23231@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mel@csn.ul.ie \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=mjw@redhat.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rdunlap@xenotime.net \
--cc=rjw@sisk.pl \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox