Re: [PATCH] VMware balloon: force compiling as a module

[Dmitry Torokhov <dtor@vmware.com>]

Hi Chetan,

On Wednesday, June 30, 2010 11:42:53 am Chetan Loke wrote:
> > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> > owner@vger.kernel.org] On Behalf Of Dmitry Torokhov
> > Sent: June 28, 2010 7:01 PM
> > VMware Tools installer requires the upstream driver to be compiled
> > as a module in order to detect its presence and avoid installing
> > our own version on top of it. To avoid surprises with 2 versions
> > of the driver being installed and fighting with each other, let's
> > force the driver to be compiled as a module unless user selects
> > CONFIG_EMBEDDED.
> > 
> >  config VMWARE_BALLOON
> >  
> >  	tristate "VMware Balloon Driver"
> > 
> > -	depends on X86
> > +	depends on X86 && (EMBEDDED || m)
> 
> None of the following questions are related to this patch.
> 
> Q1)Does vmtools handle pvscsi correctly?
> 

Yes, as long as it compiled as a module or installer will not overwrite
distribution-supplied version unless user explicitly requests installer
to clobber it.

So far distributions have not tried building their kernels with pvscsi
or vmxnet3 built-in, but did so with our ballon driver, which prompted
this particular change.

> Q2)In case if a VM wants to be a good citizen, is there a way for a
> guest to know about the balloon-event?

I am not sure I follow. Ballooning supposed to be as transparent as
possible...

> 
> Q3)What if an app mlock's its memory resources and driver's have
> pinned down their pages then how does inflation work?

We will inflate as much as we can. Obviously if there are no more
memory balloon may not grow to its full target size.

Balloon driver communicates to the hypervisor the total amount of
memory in the guest, we may want to adjust that number by subtracting
memory allocated by the kernel, mlocked memory and so on, but it is
not done currently.

Thanks.

-- 
Dmitry
> 
> 
> regards
> Chetan Loke