Re: [PATCH V3 1/5] mmc: Add erase, secure erase, trim and secure trim operations

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 24 Jun 2010 11:44:00 +0300
Adrian Hunter <adrian.hunter@nokia.com> wrote:

> SD/MMC cards tend to support an erase operation.  In addition,
> eMMC v4.4 cards can support secure erase, trim and secure trim
> operations that are all variants of the basic erase command.

The patch proposes a new userspace interface via sysfs, yes?

Please fully describe that interface and its operation in the
changelog.  It'd also be nice to add permanent documentation for it.

>From reading the code, it appears that erase_size and
preferred_erase_size have units in bytes.  But users shouldn't need to
read the code to find that out.  What are the alignemnt and size
requirements on these?  What is their position in /sys?  What do they
actually *do* and what is the difference between them?

etetera.  People want to review this code and other people actually
want to use it.  I'm not sure that I want to try to review this code
when nobody's told me what interface it implements and how it's
supposed to work.  Seems that whoever implemented BLKDISCARD didn't
want anyone to use it either.  Sigh.


All of mmc core appears to use 32-bit quantities to represent sectors,
yes?  Why didn't it use sector_t?  What are the implications of this?