From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
Andreas Dilger <adilger@dilger.ca>,
viro@zeniv.linux.org.uk, smfrench@gmail.com, jlayton@redhat.com,
mcao@us.ibm.com, aneesh.kumar@linux.vnet.ibm.com,
linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, samba-technical@lists.samba.org,
sjayaraman@suse.de, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 0/3] Extended file stat functions [ver #2]
Date: Wed, 30 Jun 2010 15:31:39 +0200 [thread overview]
Message-ID: <201006301531.39365.arnd@arndb.de> (raw)
In-Reply-To: <20100630121127.GA22713@infradead.org>
On Wednesday 30 June 2010, Christoph Hellwig wrote:
> The cost of adding a syscall is much smaller
Ack. No need for different struct layout version since we
can add another stat syscall every ten years.
> So adding a few fields of padding at the end for new members is fine,
> but doing overkill of versioning including queries for supported
> versions doesn't.
The ability to request and return a subset of the fields seems useful
regardless and it can be used to avoid the need for this kind of padding.
A sufficient amount of padding wouldn't be too bad either, but I guess
we should not have both the padding _and_ the option for extending the
structure after the padding.
With the padding, the 'size' argument can go away, though I'd argue that
even without the padding we can safely add extra fixed-length fields
when needed and not need a size argument.
Arnd
next prev parent reply other threads:[~2010-06-30 13:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 1:16 [PATCH 0/3] Extended file stat functions [ver #2] David Howells
2010-06-30 1:17 ` [PATCH 1/3] Mark arguments to certain syscalls as being const " David Howells
2010-06-30 1:17 ` [PATCH 2/3] AFS: Use i_generation not i_version for the vnode uniquifier " David Howells
2010-06-30 1:17 ` [PATCH 3/3] Add a pair of system calls to make extended file stats available " David Howells
2010-06-30 1:48 ` Trond Myklebust
2010-06-30 9:33 ` Andreas Dilger
2010-06-30 9:47 ` David Howells
2010-06-30 2:32 ` Nicholas Miell
2010-06-30 8:30 ` Arnd Bergmann
2010-06-30 8:55 ` David Howells
2010-06-30 9:31 ` Arnd Bergmann
2010-06-30 10:01 ` David Howells
2010-06-30 11:46 ` Arnd Bergmann
2010-06-30 12:14 ` David Howells
2010-06-30 12:44 ` Arnd Bergmann
2010-06-30 9:45 ` Andreas Dilger
2010-06-30 10:22 ` David Howells
2010-06-30 11:04 ` [PATCH 0/3] Extended file stat functions " Andreas Dilger
2010-06-30 12:05 ` David Howells
2010-06-30 12:11 ` Christoph Hellwig
2010-06-30 12:23 ` David Howells
2010-06-30 13:31 ` Arnd Bergmann [this message]
2010-06-30 14:05 ` Jeff Layton
2010-06-30 17:36 ` Arnd Bergmann
2010-06-30 21:45 ` Andreas Dilger
2010-06-30 23:15 ` David Howells
2010-06-30 23:27 ` H. Peter Anvin
2010-07-01 0:15 ` David Howells
2010-07-01 3:20 ` H. Peter Anvin
2010-07-01 4:57 ` Andreas Dilger
2010-07-01 8:09 ` Arnd Bergmann
2010-07-05 23:52 ` Brad Boyer
2013-11-26 10:40 ` Jan Kara
2013-11-28 13:07 ` David Howells
2013-11-28 13:57 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006301531.39365.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=adilger@dilger.ca \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcao@us.ibm.com \
--cc=samba-technical@lists.samba.org \
--cc=sjayaraman@suse.de \
--cc=smfrench@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox