From: Matthew Garrett <mjg@redhat.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Carlos Corbacho <carlos@strangeworlds.co.uk>,
Len Brown <len.brown@intel.com>, Thomas Renninger <trenn@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] wmi: fix a memory leak in wmi_notify_debug
Date: Thu, 1 Jul 2010 14:51:00 +0100 [thread overview]
Message-ID: <20100701135100.GB31804@srcf.ucam.org> (raw)
In-Reply-To: <1277688645.22992.2.camel@mola>
On Mon, Jun 28, 2010 at 09:30:45AM +0800, Axel Lin wrote:
> When acpi_evaluate_object() is passed ACPI_ALLOCATE_BUFFER,
> the caller must kfree the returned buffer if AE_OK is returned.
>
> The callers of wmi_get_event_data() pass ACPI_ALLOCATE_BUFFER,
> and thus must check its return value before accessing
> or kfree() on the buffer.
>
> This patch adds return value checking for wmi_get_event_data()
> and adds a missing kfree(obj) in the end of wmi_notify_debug
Applied, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2010-07-01 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 1:30 [PATCH] wmi: fix a memory leak in wmi_notify_debug Axel Lin
2010-06-28 12:55 ` Thomas Renninger
2010-07-01 13:51 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701135100.GB31804@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=carlos@strangeworlds.co.uk \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox