From: Matthew Garrett <mjg@redhat.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Corentin Chary <corentincj@iksaif.net>,
Len Brown <len.brown@intel.com>,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] asus-laptop: fix a memory leak in asus_laptop_get_info error path
Date: Thu, 1 Jul 2010 14:53:11 +0100 [thread overview]
Message-ID: <20100701135311.GC31804@srcf.ucam.org> (raw)
In-Reply-To: <1277780987.5478.2.camel@mola>
On Tue, Jun 29, 2010 at 11:09:47AM +0800, Axel Lin wrote:
> The callers of write_acpi_int_ret() pass ACPI_ALLOCATE_BUFFER,
> the caller must kfree the returned buffer if AE_OK is returned.
>
> This patch adds a missing kfree(buffer.pointer) before return -ENOMEM
> if kstrdup fail.
Applied, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2010-07-01 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 3:09 [PATCH] asus-laptop: fix a memory leak in asus_laptop_get_info error path Axel Lin
2010-06-29 5:30 ` Corentin Chary
2010-07-01 13:53 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701135311.GC31804@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=axel.lin@gmail.com \
--cc=corentincj@iksaif.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox